From: stephan b. <sg...@us...> - 2004-12-28 04:19:07
|
Update of /cvsroot/pclasses/pclasses2/src/s11n In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15575/src/s11n Modified Files: data_node_algo.h Log Message: Added a reminder note about a bug-in-waiting. Index: data_node_algo.h =================================================================== RCS file: /cvsroot/pclasses/pclasses2/src/s11n/data_node_algo.h,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- data_node_algo.h 26 Dec 2004 07:53:19 -0000 1.3 +++ data_node_algo.h 28 Dec 2004 04:18:52 -0000 1.4 @@ -93,6 +93,12 @@ target.begin() ), s11n::same_name<NodeT>( name ) ); + // ^^^^ BUG: this only works when NodeT::name() is public, + // as it avoids node_traits<>! + // In 1.1 s11n_node::name() might be made private, and node_traits<> + // will be his only friend. Then this bug will show up. + // s11n::data_node is frozen: he won't change, but s11nlite + // might switch to using s11n_node in 1.1! // you gotta love the STL, man. return target.size() - c; } |