From: Andrew M. (JIRA) <ji...@pc...> - 2010-10-21 21:46:52
|
Expand HIDETYPE to include 'ABILITYPOOL' ---------------------------------------- Key: NEWTAG-218 URL: http://jira.pcgen.org/browse/NEWTAG-218 Project: New Tag Issue Type: Modify Token Reporter: Andrew Maitland HIDETYPE:FEAT| is great at hiding things, but it applies universally across ALL Abilitycategories, not just Feats. HIDETYPE:ABILITYPOOL|<Pool aka ABILITYCATEGORY>|<TYPE> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Andrew M. (JIRA) <ji...@pc...> - 2010-10-21 23:16:52
|
[ http://jira.pcgen.org/browse/NEWTAG-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Maitland updated NEWTAG-218: ----------------------------------- Description: HIDETYPE:FEAT| is great at hiding things, but it applies universally across ALL Abilitycategories, not just Feats. New Format: HIDETYPE:ABILITYPOOL|<Pool aka ABILITYCATEGORY>|<TYPE> We'll need to deprecate the behavior in HIDETYPE:FEAT to not go beyond Feat File TYPEs. What I want this to handle is ONLY designated TYPEs of a Certain ABILITYPOOL/ABILITYCATEGORY are hidden in the Types. For Instance, GENERAL in Feat is something I want to see, but "ExtraFoo" I don't want to see. But in another AbilityPool I want to See "ExtraFoo" This should be smart enough to Filter ONLY the designated Categories we designate - Filter By ABILITYPOOL/ABILITYCATEGORY. We can leave HIDETYPE:FEAT as is, we just need to remove the over-reaching ability to Filter ALL Abilities regardless of ABILITYPOOL. I'm unsure whether ABILITYCATEGORY would be better, ABILITYPOOL and ABILITYCATEGORY are interchangeable at this point. Interactions I'm unsure of: Master Ability Categories vs. Children. If someone Sets HIDETYPE:ABILITYPOOL|Special Ability|General Since Special Ability is a Parent/Master it would affect all children under it I would imagine. I'm not sure if this is desirable or not, but for the moment, I think it's fine if that is the end result. As that will likely save time. was: HIDETYPE:FEAT| is great at hiding things, but it applies universally across ALL Abilitycategories, not just Feats. HIDETYPE:ABILITYPOOL|<Pool aka ABILITYCATEGORY>|<TYPE> > Expand HIDETYPE to include 'ABILITYPOOL' > ---------------------------------------- > > Key: NEWTAG-218 > URL: http://jira.pcgen.org/browse/NEWTAG-218 > Project: New Tag > Issue Type: Modify Token > Reporter: Andrew Maitland > > HIDETYPE:FEAT| is great at hiding things, but it applies universally across ALL Abilitycategories, not just Feats. > New Format: > HIDETYPE:ABILITYPOOL|<Pool aka ABILITYCATEGORY>|<TYPE> > We'll need to deprecate the behavior in HIDETYPE:FEAT to not go beyond Feat File TYPEs. > What I want this to handle is ONLY designated TYPEs of a Certain ABILITYPOOL/ABILITYCATEGORY are hidden in the Types. > For Instance, GENERAL in Feat is something I want to see, but "ExtraFoo" I don't want to see. But in another AbilityPool I want to See "ExtraFoo" > This should be smart enough to Filter ONLY the designated Categories we designate - Filter By ABILITYPOOL/ABILITYCATEGORY. > We can leave HIDETYPE:FEAT as is, we just need to remove the over-reaching ability to Filter ALL Abilities regardless of ABILITYPOOL. > I'm unsure whether ABILITYCATEGORY would be better, ABILITYPOOL and ABILITYCATEGORY are interchangeable at this point. > Interactions I'm unsure of: > Master Ability Categories vs. Children. > If someone Sets > HIDETYPE:ABILITYPOOL|Special Ability|General > Since Special Ability is a Parent/Master it would affect all children under it I would imagine. I'm not sure if this is desirable or not, but for the moment, I think it's fine if that is the end result. As that will likely save time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. A. M. ) <ji...@pc...> - 2011-12-02 22:21:07
|
[ http://jira.pcgen.org/browse/NEWTAG-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12818#action_12818 ] Andrew Maitland commented on NEWTAG-218: ---------------------------------------- Moving Comments over from NEWTAG-259 to consolidate it in one place: Stefan Radermacher added a comment - 04/May/11 8:06 PM It turns out that HIDETYPE:FEAT works for all ability objects. However, it seems counter-intuitive to use HIDETYPE:FEAT to hide ability types for non-feat abilities. However, simply adding HIDETYPE:ABILITY with the same functionality could possibly cause problems, as both feats and other abilities internally use the Ability class, and the unparse function for the HIDETYPE tag cannot differentiate between them. Thus both would unparse to either both HIDETYPE:FEAT or HIDETYPE:ABILITY. I am not sure if this really is a problem. Maybe it could cause memory leaks when unloading the datasets? Possibly Tom can shed some light on that. As a solution I would propose to implement HIDETYPE:ABILITY as indicated above and at the same time deprecate HIDETYPE:FEAT and replace all occurrences of HIDETYPE:FEAT in all datasets with HIDETYPE:ABILITY, and use only HIDETYPE:ABILITY from this time on. Any comments anyone? James Dempsey added a comment - 04/May/11 9:24 PM In transferring to HIDETYPE:ABILITY I think we should be considering categories as it would most likely to be desirable to hide a type only within a category. I'll transfer this tracker to the NEWTAG project. Could you raise the syntax discussion on the exp list please? Andrew Maitland added a comment - 05/May/11 2:10 AM I'm all for this. I have several sets that could use this solution. > Expand HIDETYPE to include 'ABILITYPOOL' > ---------------------------------------- > > Key: NEWTAG-218 > URL: http://jira.pcgen.org/browse/NEWTAG-218 > Project: New Tag > Issue Type: Modify Token > Reporter: Andrew Maitland > > HIDETYPE:FEAT| is great at hiding things, but it applies universally across ALL Abilitycategories, not just Feats. > New Format: > HIDETYPE:ABILITYPOOL|<Pool aka ABILITYCATEGORY>|<TYPE> > We'll need to deprecate the behavior in HIDETYPE:FEAT to not go beyond Feat File TYPEs. > What I want this to handle is ONLY designated TYPEs of a Certain ABILITYPOOL/ABILITYCATEGORY are hidden in the Types. > For Instance, GENERAL in Feat is something I want to see, but "ExtraFoo" I don't want to see. But in another AbilityPool I want to See "ExtraFoo" > This should be smart enough to Filter ONLY the designated Categories we designate - Filter By ABILITYPOOL/ABILITYCATEGORY. > We can leave HIDETYPE:FEAT as is, we just need to remove the over-reaching ability to Filter ALL Abilities regardless of ABILITYPOOL. > I'm unsure whether ABILITYCATEGORY would be better, ABILITYPOOL and ABILITYCATEGORY are interchangeable at this point. > Interactions I'm unsure of: > Master Ability Categories vs. Children. > If someone Sets > HIDETYPE:ABILITYPOOL|Special Ability|General > Since Special Ability is a Parent/Master it would affect all children under it I would imagine. I'm not sure if this is desirable or not, but for the moment, I think it's fine if that is the end result. As that will likely save time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. A. M. ) <ji...@pc...> - 2012-03-04 23:14:48
|
<style> /* Changing the layout to use less space for mobiles */ @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; } #email-page { padding: 8px !important; } #email-banner { padding: 8px 8px 0 8px !important; } #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; } #email-fields { padding: 0 8px 8px 8px !important; } #email-gutter { width: 0 !important; } } </style> <div id="email-body"> <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top"> <td id="email-page" style="padding:16px !important;"> <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> <tr valign="top"> <td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td> </tr><tr valign="top"> <td id="email-banner" style="padding:32px 32px 0 32px;"> <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;"> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;"> <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?ownerId=legacyking&avatarId=10320" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" /> <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="legacyking" id="email_legacyking" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=legacyking" style="color:#3c78b5;">Andrew Maitland</a> updated <img src="http://jira.pcgen.org/images/icons/genericissue.gif" height="16" width="16" border="0" align="absmiddle" alt="Modify Token"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-218'>NEWTAG-218</a> </div> <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/NEWTAG-218"><strong>Expand HIDETYPE to include 'ABILITYPOOL'</strong></a> </div> </td> </tr> </table> </td> </tr> <tr valign="top"> <td id="email-fields" style="padding:0 32px 32px 32px;"> <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top"> <td id="email-gutter" style="width:64px;white-space:nowrap;"></td> <td> <table border="0" cellpadding="0" cellspacing="0" width="100%"> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Change By:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <a class="user-hover" rel="legacyking" id="email_legacyking" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=legacyking" style="color:#3c78b5;">Andrew Maitland</a> (05/Mar/12 10:13 AM) </td> </tr> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Status:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Proposed</span> <span class="diffaddedchars" style="background-color:#ddfade;">In Discussion</span> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </td><!-- End #email-page --> </tr> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;"> This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br /> For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a> </td> </tr> </table><!-- End #email-wrap --> </div><!-- End #email-body --> |
From: JIRA (f. A. M. ) <ji...@pc...> - 2012-03-04 23:23:47
|
<style> /* Changing the layout to use less space for mobiles */ @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; } #email-page { padding: 8px !important; } #email-banner { padding: 8px 8px 0 8px !important; } #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; } #email-fields { padding: 0 8px 8px 8px !important; } #email-gutter { width: 0 !important; } } </style> <div id="email-body"> <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top"> <td id="email-page" style="padding:16px !important;"> <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> <tr valign="top"> <td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td> </tr><tr valign="top"> <td id="email-banner" style="padding:32px 32px 0 32px;"> <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;"> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;"> <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?ownerId=legacyking&avatarId=10320" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" /> <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="legacyking" id="email_legacyking" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=legacyking" style="color:#3c78b5;">Andrew Maitland</a> commented on <img src="http://jira.pcgen.org/images/icons/genericissue.gif" height="16" width="16" border="0" align="absmiddle" alt="Modify Token"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-218'>NEWTAG-218</a> </div> <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/NEWTAG-218"><strong>Expand HIDETYPE to include 'ABILITYPOOL'</strong></a> </div> </td> </tr> </table> </td> </tr> <tr valign="top"> <td id="email-fields" style="padding:0 32px 32px 32px;"> <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top"> <td id="email-gutter" style="width:64px;white-space:nowrap;"></td> <td> <table border="0" cellpadding="0" cellspacing="0" width="100%"> <tr valign="top"> <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;"> <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">Bumped Discussion for final review and posting of the final syntax here. </div> <div style="color:#505050;padding:4px 0 0 0;"> </div> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </td><!-- End #email-page --> </tr> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;"> This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br /> For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a> </td> </tr> </table><!-- End #email-wrap --> </div><!-- End #email-body --> |
From: JIRA (f. A. M. ) <ji...@pc...> - 2012-03-04 23:32:48
|
<style> /* Changing the layout to use less space for mobiles */ @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; } #email-page { padding: 8px !important; } #email-banner { padding: 8px 8px 0 8px !important; } #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; } #email-fields { padding: 0 8px 8px 8px !important; } #email-gutter { width: 0 !important; } } </style> <div id="email-body"> <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top"> <td id="email-page" style="padding:16px !important;"> <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> <tr valign="top"> <td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td> </tr><tr valign="top"> <td id="email-banner" style="padding:32px 32px 0 32px;"> <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;"> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;"> <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?ownerId=legacyking&avatarId=10320" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" /> <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="legacyking" id="email_legacyking" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=legacyking" style="color:#3c78b5;">Andrew Maitland</a> commented on <img src="http://jira.pcgen.org/images/icons/genericissue.gif" height="16" width="16" border="0" align="absmiddle" alt="Modify Token"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-218'>NEWTAG-218</a> </div> <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/NEWTAG-218"><strong>Expand HIDETYPE to include 'ABILITYPOOL'</strong></a> </div> </td> </tr> </table> </td> </tr> <tr valign="top"> <td id="email-fields" style="padding:0 32px 32px 32px;"> <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top"> <td id="email-gutter" style="width:64px;white-space:nowrap;"></td> <td> <table border="0" cellpadding="0" cellspacing="0" width="100%"> <tr valign="top"> <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;"> <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">Per Stefan - <br/> <br/> As Andrew indicated, the option to hide ability types should be refined <br/> in a way so that ability types can be hidden for certain ability <br/> categories only, meaning both main categories (e.g. "Special Ability", <br/> or "Archetype") and individual ability pools, too. <br/> <br/> The HIDETYPE syntax would add/change this: <br/> <br/> Variables Used (x): ABILITYCATEGORY=z (Ability types in the ability <br/> category (z) will be hidden) <br/> <br/> Variables Used (x): FEAT (Feat Types will be hidden, shorthand for <br/> ABILITYCATEGORY=FEAT)</div> <div style="color:#505050;padding:4px 0 0 0;"> </div> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </td><!-- End #email-page --> </tr> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;"> This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br /> For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a> </td> </tr> </table><!-- End #email-wrap --> </div><!-- End #email-body --> |