From: SourceForge.net <no...@so...> - 2007-10-19 22:46:52
|
Feature Requests item #1816819, was opened at 2007-10-19 15:46 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1816819&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: LegacyKing (amaitland) Assigned to: Nobody/Anonymous (nobody) Summary: [Tir] Counting Ability Objects by TYPE Initial Comment: The count() JEP function now works in FOR tokens, when I added OS blocks for Mutations and Salient Abilities it didn't so thanks James or whoever fixed that :) The docs list CATEGORY, VISIBILITY and NATURE for the parameters you can count Abilities with, we're going to need TYPE added to that. The Ability tokens (like the FEAT tokens) allow for generating a list based on a specified TYPE but without the ability to count by type this is fairly limiting. +++ The docs also include TYPE. ABILITIES - Will count the abilities that satisfy the included "CATEGORY", "NATURE", "TYPE", and "VISIBILITY" parameters. and "TYPE=<text>" - The ability type as defined in the ability.lst file. (i.e. "General", "Fighter", "Metamagic", etc.) Eric +++ Hi Eric That's excellent news. OK I figured out why I didn't see that, I was looking at the entry on the JEP page which does not list that: http://pcgen.sourceforge.net/autobuilds/pcgen-docs/listfilepages/globalfilestagpages/globalfilesformulas.html#count +++ Glad I could help clear it up . . . :-) Which actually allows me to segway into something I mentioned when I was adding the count() docs to the OS Docs, I feel we need to address the jep docs issue more completely . . . So, I have a question for James and the rest of the Code Monkeys . . . or anone else who can answer the questions . . . :-) does the current jep count(), as documented in the OS Docs apply to only the OS? Or can the command be used in lst files as well? If the jep commands are implemented specifically for one or the other, that being OSes or lst files, than we will need to add a jep section under the OS docs. What I'm envisioning is a separate page called 'outputsheettokensjep.html' which can contain the OS specific jep commands, and maybe even duplicating the common jep info so you don't have to refer back to the lst file jep page, which already exists. Is there value added in this? Eric Smith Doc 2nd PCGen Project +++ I thought JEP stuff was usable everywhere in the same format. So if an OS token takes math and JEP, any JEP usage can be used there. Same with LST tokens. Beyond that, I can't really comment, since I'm not sure the best way to present it. +++ If there is ANY difference in how the jep command is applied between OSes and LST files, then we will need to separate the docs for those. If there aren't any differences, then its a different matter . . . Here are a few additional questions for anyone willing to answer . . . Do you have to implement each 'parameter' used in the jep count in the code? (Shoot! . . . the hay guys got here while I was posting this and I forgot my other questions . . . ) Oh well . . . Where can I go to get a better understanding of jep? Eric +++ Nice to know. I did the same thing. I'm @ work. Is "NAME=" one of those? Needed for LST files. Like, how many times a character has Weapon Focus.... -- Tir Gwaith +++ I'm doing the jep count() stuff. I have TYPE= checking added in my local repository but haven't committed it. I ran into problems with some of the other counts in that I need to figure out what is attached to and active on a pc. That's going to change under cdom and I don't want to write lots of intricat code taht's going to get ripped out and replaced with cdom accesses in the next couple of months. If you want me to commit the Ability stuff, I could probably whip that into a reasonable shape fairly quickly. Jep is common across LST and the OS. andrew +++ I take it that that means counting by ability TYPE in the docs is not yet implemented? Yes, please do get the Ability stuff in, the other stuff is a replacement for COUNT[ ] but COUNT[ ] doesn't work with Abilities (which was the reason for count() in the first place). Anything we can do now with COUNT[ ] is a low priority in my mind. Thanks. -- ~ Eddy Anthony (MoSaT) +++ I did a little testing and answered my own question. It appears that counting by TYPE is implemented, I've got a test block fully functional. I am seeing a releated error message in the console though: 13:30:09.94 SEVERE AWT-EventQueue-1 CountCommand:224 Bad paramter to count("Ability"), no such Visibility VISIBLE -- ~ Eddy Anthony (MoSaT) +++ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1816819&group_id=25576 |