From: SourceForge.net <no...@so...> - 2007-06-28 00:48:46
|
Plugin Bugs item #1744534, was opened at 2007-06-27 20:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Initiative Module Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Maelen (maelen) Assigned to: Nobody/Anonymous (nobody) Summary: Initiative lost during re-sort Initial Comment: In 5.11 branch, if initiative is entered manually and plugin needs to sort, initiative value is lost. I did not see this problem in 5.10. I checked out the code and it seems to be somewhere around editTable() in Initiative.java ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 |
From: SourceForge.net <no...@so...> - 2007-06-28 00:55:44
|
Plugin Bugs item #1744534, was opened at 2007-06-27 20:48 Message generated for change (Comment added) made by maelen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Initiative Module Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Maelen (maelen) Assigned to: Nobody/Anonymous (nobody) Summary: Initiative lost during re-sort Initial Comment: In 5.11 branch, if initiative is entered manually and plugin needs to sort, initiative value is lost. I did not see this problem in 5.10. I checked out the code and it seems to be somewhere around editTable() in Initiative.java ---------------------------------------------------------------------- >Comment By: Maelen (maelen) Date: 2007-06-27 20:55 Message: Logged In: YES user_id=1088497 Originator: YES The exact version was Pcgen Unstable 5.12.0 Rc3 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 |
From: SourceForge.net <no...@so...> - 2008-02-11 11:43:41
|
Plugin Bugs item #1744534, was opened at 2007-06-28 01:48 Message generated for change (Settings changed) made by karianna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Initiative Module >Group: To be Fixed for 5.14 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Maelen (maelen) Assigned to: Nobody/Anonymous (nobody) Summary: Initiative lost during re-sort Initial Comment: In 5.11 branch, if initiative is entered manually and plugin needs to sort, initiative value is lost. I did not see this problem in 5.10. I checked out the code and it seems to be somewhere around editTable() in Initiative.java ---------------------------------------------------------------------- Comment By: Maelen (maelen) Date: 2007-06-28 01:55 Message: Logged In: YES user_id=1088497 Originator: YES The exact version was Pcgen Unstable 5.12.0 Rc3 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 |
From: SourceForge.net <no...@so...> - 2008-02-14 16:46:37
|
Plugin Bugs item #1744534, was opened at 2007-06-28 01:48 Message generated for change (Comment added) made by karianna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Initiative Module Group: To be Fixed for 5.14 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Maelen (maelen) >Assigned to: Martijn Verburg (karianna) Summary: Initiative lost during re-sort Initial Comment: In 5.11 branch, if initiative is entered manually and plugin needs to sort, initiative value is lost. I did not see this problem in 5.10. I checked out the code and it seems to be somewhere around editTable() in Initiative.java ---------------------------------------------------------------------- >Comment By: Martijn Verburg (karianna) Date: 2008-02-14 16:46 Message: Logged In: YES user_id=252169 Originator: NO Confirmed, to replicate, manually edit the initiative field so that the character/monster moves up or down in the initiative order. When the row containing that PC/monster moves, the new initiative value is lost and the previous initiative is displayed. I'll try to take a look as to why (but I'm no Java Swing programmer) - K ---------------------------------------------------------------------- Comment By: Maelen (maelen) Date: 2007-06-28 01:55 Message: Logged In: YES user_id=1088497 Originator: YES The exact version was Pcgen Unstable 5.12.0 Rc3 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 |
From: SourceForge.net <no...@so...> - 2008-02-14 17:53:21
|
Plugin Bugs item #1744534, was opened at 2007-06-28 01:48 Message generated for change (Comment added) made by karianna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Initiative Module Group: To be Fixed for 5.14 >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Maelen (maelen) Assigned to: Martijn Verburg (karianna) Summary: Initiative lost during re-sort Initial Comment: In 5.11 branch, if initiative is entered manually and plugin needs to sort, initiative value is lost. I did not see this problem in 5.10. I checked out the code and it seems to be somewhere around editTable() in Initiative.java ---------------------------------------------------------------------- >Comment By: Martijn Verburg (karianna) Date: 2008-02-14 17:53 Message: Logged In: YES user_id=252169 Originator: NO I can see that a java.lang.IndexOutOfBoundsException: Index: 2, Size: 2 exception occurs, it is thrown from the line: InitHolder iH = initList.get(activeRow); in the method below. private void editTable(int row, int column) { int activeRow = 0; for (int i = 0; i < initList.size(); i++) { InitHolder c = initList.get(i); if ((!c.getStatus().equals("Dead") || showDead.isSelected()) && (!(c instanceof Event) || showEvents.isSelected())) { activeRow++; } } InitHolder iH = initList.get(activeRow); Object data = combatantTable.getValueAt(row, column); boolean atTop = (currentInit == initList.getMaxInit()); iH.editRow(columnList, column, data); initHolderUpdated(iH); initList.sort(); if (atTop) { setCurrentInit(initList.getMaxInit()); } refreshTable(); } It's a classic case of arrays starting indexes at 0 not 1, have fixed, tested and committed a change so that the erroneous line now states: InitHolder iH = initList.get(activeRow - 1); K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-02-14 16:46 Message: Logged In: YES user_id=252169 Originator: NO Confirmed, to replicate, manually edit the initiative field so that the character/monster moves up or down in the initiative order. When the row containing that PC/monster moves, the new initiative value is lost and the previous initiative is displayed. I'll try to take a look as to why (but I'm no Java Swing programmer) - K ---------------------------------------------------------------------- Comment By: Maelen (maelen) Date: 2007-06-28 01:55 Message: Logged In: YES user_id=1088497 Originator: YES The exact version was Pcgen Unstable 5.12.0 Rc3 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=627102&aid=1744534&group_id=25576 |