[Pcgen-trackers] [ pcgen-Bugs-1171676 ] Skils Editor - PREREQs written out as XML

[SourceForge.net <no...@so...>]

Bugs item #1171676, was opened at 2005-03-27 23:33
Message generated for change (Comment added) made by soulcatcher
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1171676&group_id=25576

Category: LST Editor
Group: None
Status: Open
Resolution: None
Priority: 9
Submitted By: James Dempsey (jdempsey)
>Assigned to: Nobody/Anonymous (nobody)
Summary: Skils Editor - PREREQs written out as XML

Initial Comment:
When a synergy is added to a skill entry, the PRESKILL
requirement is written out as an XML string rather than
an LST string. This breaks the parsing of the skill
when it is later loaded.

e.g. BONUS:SKILL|COPY OF BALANCE|2|<PREREQ KIND="SKILL"
KEY="BALANCE" OPERATOR="GTEQ" OPERAND="5" >
</PREREQ>
|TYPE=SYNERGY.STACK

The bponus is also written out twice, one for when it
is in the advanced tab and once for the synergy tab.

----------------------------------------------------------------------

>Comment By: Devon Jones (soulcatcher)
Date: 2005-04-08 10:23

Message:
Logged In: YES 
user_id=107647

Assigning to nobody, as per my email to the devel list on
sunday.  hunterc is welcome to take this bug back, but in
order to get to release, we need to let people who have the
time knock these bugs off.

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2005-04-06 02:38

Message:
Logged In: YES 
user_id=558288

What I had envisaged for this bug was creating a getPCCText
function in pcgen.core.prereq.Prerequisite which output the
prereq in PCC format (as Tir supplied) rather than XML. This
could be called from the PObject getPCCText when it is
building the output to be saved, rather than calling
toString on the prereq. IM me if you want to discuss it further.

BTW: If you change the toString method in prereq you'll get
a heap of unit test failures as many of these are checking
the output of the prereqs to check the interpretation and
parsing of prereqs.

James.

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-04-05 17:32

Message:
Logged In: YES 
user_id=208239

<PREREQ KIND="SKILL"
KEY="BALANCE" OPERATOR="GTEQ" OPERAND="5" >
</PREREQ>

is 
PRESKILL:1,Balance=5
:)

----------------------------------------------------------------------

Comment By: HunterCottage (hunterc)
Date: 2005-04-05 17:09

Message:
Logged In: YES 
user_id=1239235

The toString() functin in
java/pcgen/core/prereq/Prerequiste.java is sending the XML
formatted string <PREREQ KIND="SKILL"
KEY="BALANCE" OPERATOR="GTEQ" OPERAND="5" >
</PREREQ>, but in lowercase letters,  which causes an error
somehow. 

At one point, I think in was in the Skill() block of the
class Skill. Eclipse printed in red that
"pcgen.core.bonus.BounusObj could not resolve to a Java
object."  I got an InvocationException thrown while stepping
through the code in Debug mode. Nothing happened and I was
able to continue stepping through the code. The output was a
little different when I looked at the customSkill.lst, the
output was SKILL | ERROR instead of the XML formatted text.

Any thoughts would be great on what to do next, since I am
unsure of what tags and such are supposed to be placed in
the customSkill.lst file and I don't understand why the
toString() is being formatted to XML..

Cheers,

Brian Kuehn

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-04-02 09:16

Message:
Logged In: YES 
user_id=107647

Yes, this is approved.

----------------------------------------------------------------------

Comment By: Paul W. King (kingpaul)
Date: 2005-03-28 07:43

Message:
Logged In: YES 
user_id=277877

Flagging for Devon to see if should be included in 5.8

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1171676&group_id=25576