From: SourceForge.net <no...@so...> - 2005-01-24 14:36:19
|
Bugs item #1107936, was opened at 2005-01-23 20:27 Message generated for change (Comment added) made by frugal You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1107936&group_id=25576 Category: None Group: None >Status: Deleted >Resolution: Duplicate Priority: 7 Submitted By: Paul W. King (kingpaul) >Assigned to: Frugal (frugal) Summary: jep not ignoring MIN as part of class name Initial Comment: From http://groups.yahoo.com/group/pcgen/message/82918 >>> I had to look at the debug stuff for a few minutes >>> to find the problem but I have. >>> >>> CL=Warmind and BL=Warmind are being interpreted >>> as (War)Min(D) and so is not giving a proper >>> response. Need to reformate it in jep style. >>> >>> The entries for warmind should change to >>> BONUS:VAR|WarmindML|var("CL=Warmind") and >>> BONUS:VAR|WarmindML|var("BL=Warmind") >>> >>> All of the other WarmindML entries may need to >>> change to var("WarmindML") but I'm not sure. Can >>> a jep expert LMK? >>> >>> May as well update all of the other similar class >>> entries in psionics will I'm at it. > > Okay there is a problem here. > > If a class has MIN in the name (such as Warmind or > War Mind) then CL= and BL= don't work correctly. The > jep expressions don't work [var("CL=Warmind")] > correctly either. > In the debug screen there are always listed as > checking CL=Warmin (dropping the 'D'). > > I change Warmind to Warm1nd (replacing 'i' with '1' > (one not L) and it works correctly. Maybe a quick fix would be to allow CL='class name' and making sure that the quoted text is not interpreted again. BTW, this, among other things, is why the CL=, BL=, etc. hacks have to go. === Paul W. King TM SB, OGL/PL Chimp, Data Gibbon, BoD ---------------------------------------------------------------------- >Comment By: Frugal (frugal) Date: 2005-01-24 14:36 Message: Logged In: YES user_id=4807 I accidentaly opened a separate tracker for this one when I fixed it, so I am closing this one as a duplicate. regards, Frugal ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-01-23 23:34 Message: Logged In: YES user_id=324612 The Jep parser call the old paser when it needs to resolve things like CL=Class name. It's the old parser that is having an issue and this is why I've been wanting the CL=xxx and such hacks to go away for quite some time now. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-01-23 22:33 Message: Logged In: YES user_id=208239 I think the real problem is the old parser getting involved in JEP calculations. MIN or min shouldn't mean a thing. MIN() or min() should, according to JEP. The fact that it is working like the old parser (var1)MIN(var2) type evaluation, means that the old parser is rearing it's head inside JEP calculations. ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-01-23 20:51 Message: Logged In: YES user_id=324612 The other options would be to implement the VAR= as Jep function right away: CL= would become CL("") BL= would become BL("") etc. it would be doable to convert all the var("CL=xxx") to CL ("xxx") but it's not even needed for 5.8. The existance of CL ("") functions would allow us to deal with the wierd cases like the winmind that have min in the class name. Assigning to Devon for his oppinion. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1107936&group_id=25576 |