|
From: SourceForge.net <no...@so...> - 2004-09-19 07:45:11
|
Bugs item #1022235, was opened at 2004-09-04 16:20 Message generated for change (Comment added) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1022235&group_id=25576 Category: Other Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: James Dempsey (jdempsey) Assigned to: James Dempsey (jdempsey) Summary: PREITEM in BONUS does not work Initial Comment: Transferred from 1021541 ] [5.7.4] ! in !PRExxx tags not working: BONUS:SKILL|Ride|-5|!PREITEM:1,TYPE.Saddle|PREAPPLY:PC does not work. The PREAPPLY:PC option makes it appear on the temporary bonus tags page, but the PREITEM option does nothing. ---------------------------------------------------------------------- >Comment By: James Dempsey (jdempsey) Date: 2004-09-19 17:45 Message: Logged In: YES user_id=558288 Two problems were present here. First the PREITEM tag had its comparisons around the wrong way, so !PREITEM would never be satisfied. PREUATT and PRESHIELDPROF both had the same problem. All three have been corrected. This correction has activated the no-tools penalties for craft skills in the LST files. The other problem was that prerequisites in temporary modifiers were being ignored. Full support for these has now been added. So a temp modifier has to be both enabled and qualified for before it takes effect. Files changed: src/java/pcgen/core/bonus/BonusObj.java new revision: 1.36 src/java/pcgen/core/PlayerCharacter.java new revision: 1.1416 src/java/pcgen/core/prereq/PreItem.java new revision: 1.7 src/java/pcgen/core/prereq/PreShieldProficiency.java new revision: 1.7 src/java/pcgen/core/prereq/PreUnarmedAttack.java new revision: 1.9 src/java/pcgen/gui/tabs/InfoTempMod.java new revision: 1.67 src/java/pcgen/io/PCGVer2Creator.java new revision: 1.108 testsuite/csheets/BarJack.xml new revision: 1.6 testsuite/csheets/BrdJoe.xml new revision: 1.5 testsuite/csheets/CleElf.xml new revision: 1.6 testsuite/csheets/FigFae.xml new revision: 1.4 testsuite/csheets/MonKee.xml new revision: 1.5 testsuite/csheets/SWizSam.xml new revision: 1.6 testsuite/csheets/WizShar.xml new revision: 1.5 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1022235&group_id=25576 |