[Pcgen-trackers_code] [JIRA] (CODE-1945) Do not unload characters when *adding* sources

[JIRA (f. T. P. ) <ji...@pc...>]

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#003366" style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US7r5c5v-418945332/812/6/_/images/icon-jira-logo.png" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                            &nbsp;                         <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="thpr" id="email_thpr" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=thpr" style="color:#326ca6;">Tom Parker</a>
     edited a comment on <img src="http://jira.pcgen.org/images/icons/newfeature.gif" height="16" width="16" border="0" align="absmiddle" alt="New Feature"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-1945'>CODE-1945</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-1945'><strong>Do not unload characters when *adding* sources</strong></a>
            </div>
                    </td>
    </tr>
</table>
        
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Adding a source while a character is loaded can result in complete disaster.  This is VERY VERY hard to work around.<br/>
The "counter-example" here is:<br/>
MyFeat &lt;&gt; ...<br/>
New Source:<br/>
MyFeat.MOD &lt;&gt; PRESTAT:INT=13 &lt;&gt; AUTO:LANG|Draconic</p>

<p>With the new load, we would neither:<br/>
(1) Catch the PRESTAT presence<br/>
(2) Give the character the Draconic Language (since this was processed ONLY has MyFeat was added to the character; content is NOT continuously evaluated for performance reasons)</p>

<p>The "intelligence" to recognize that an item was modified and needs to be re-run through the systems is non-trivial, and cannot simply be "remove and readd anything that changed" especially since some items (Templates) are order dependent.  It is effectively "remove and re-add everything" also known as "reload the character".</p>

<p>Also, we get into tons of other problems such as "overwrite items from newer sources" as well as things that fit into a collection (AUTO:LANGUAGE|TYPE=European) that result in similar (or worse) issues.</p>

<p>I'm open to the alternative, I'm not sure why the PC can override the sources loaded (that doesn't seem like good behavior to me)</p></div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your JIRA administrators<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->