[Pcgen-team-content] [JIRA] Resolved: (DATA-492) PFCR: Magic Vestment temporary bonus implementation is incorrect

[JIRA (f. P. S. ) <ji...@pc...>]

     [ http://jira.pcgen.org/browse/DATA-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Shipley resolved DATA-492.
-------------------------------

    Resolution: Fixed

SVN-15688

> PFCR: Magic Vestment temporary bonus implementation is incorrect
> ----------------------------------------------------------------
>
>                 Key: DATA-492
>                 URL: http://jira.pcgen.org/browse/DATA-492
>             Project: Data
>          Issue Type: Bug
>          Components: Pathfinder
>    Affects Versions: 5.17.9
>         Environment: WinXP
>            Reporter: Paul Shipley
>            Assignee: Paul Shipley
>             Fix For: 5.17.10
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> The temporary bonus from Magic Vestment is implemented in a peculiar way in pfcr_spells.lst.  It's implemented as an armor & shield bonus with an offset for the magic enhancement of the piece of equipment.  In fact it should be an enhancement bonus, and there's no need for the offset as the stacking system will take care of it.  There is a second problem in that it gives *both* and armor & shield bonus as the type of kit used to PREAPPLY doesn't seem to affect which version of the bonus gets used.  It doesn't work for many combinations of items.
> Examples:
> 1) Wearing full plate +1 with Magic Vestment [lvl 9 = +2] & light steel shield +2, combination should give armor +9, armor enhancement +2, shield +1, shield enhancement +2 for AC24, everything else being equal.  pcgen gives AC23 (+10 total armor & +3 total shield)
> 2) Any outfit with Magic Vestment [lvl 9 = +2] should give armor +0, armor enhancement +2, no shield for AC12.  pcgen gives AC14 (+2 total armor & +2 total shield (!))

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira