From: SourceForge.net <no...@so...> - 2011-06-24 12:58:14
|
Bugs item #1687659, was opened at 2007-03-24 21:26 Message generated for change (Comment added) made by papa_drb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1687659&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Equipment/Weaponprof Support Group: To be Fixed for 6.0 >Status: Deleted Resolution: None Priority: 5 Private: No Submitted By: Tom Parker (thpr) Assigned to: Nobody/Anonymous (nobody) Summary: Eq Customizer ignores PLUS: Token restrictions after removal Initial Comment: Weapon Editor does not enforce PLUS when removing the + modifier. e.g. you can: Customize Longsword - Bane is not available Make it +1 - Bane is now available Add Bane(Dragons) Remove +1, leaving Bane - Except Bane should be illegal ---------------------------------------------------------------------- >Comment By: David R. Bender (papa_drb) Date: 2011-06-24 08:58 Message: http://jira.pcgen.org/browse/CODE-669 ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-11-03 16:39 Message: It hasn't been reschedule, it was in the 5.16.0 bucket when I reviewed it today, I was more concerned with whether it was doable or whether it should wait until 6.0 code. ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-11-03 11:58 Message: I'm not comfortable that things are being rescheduled at this point in the calendar, especially given the significant amount of work we have remaining to get to beta. Having said that, this is not my decision - it is an issue for James as the Code lead to define what is and isn't required for release of 5.16. Arch requirements for 5.16 are the tokens, which "closes" at the end of alpha. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-11-03 10:42 Message: Hi Tom, Is this something that can actually be tackled in 5.16? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-04-15 08:12 Message: Logged In: YES user_id=252169 Originator: NO Ah submitted by Tom, back to 6.0 ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-04-15 08:05 Message: Logged In: YES user_id=252169 Originator: NO Can't see reason for it to be in 6.0, moving to 5.14 - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2007-04-25 10:09 Message: Logged In: YES user_id=252169 Originator: NO confirmed, code dealing with this is in Equipment.java, in particular the method: public void removeEqModifier(final EquipmentModifier eqMod, final boolean bPrimary) { .. .. if (false) removeUnqualified(bPrimary); // TODO: used? ) The removeUnqualified() method itself has a comment: // The problem is that you have entries // like the following for Adamantine: // PRETYPE:Weapon,Metal !PRETYPE:Masterwork // Which have nothing to do with the eqMod, so // they are always going to fail and be removed. // The entries in equip_enhancing are used by // the GUI to know what to display, not for // actual passesPreReq checks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1687659&group_id=25576 |