[Pcgen-trackers] [JIRA] Resolved: (DATA-64) Fix for BROKEN Armor Eqmod issue

[Andrew M. (JIRA) <ji...@pc...>]

     [ http://jira.pcgen.org/browse/DATA-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Maitland resolved DATA-64.
---------------------------------

    Fix Version/s: 5.17.4 (Alpha)
       Resolution: Fixed

Completed: At revision: 12886  


> Fix for BROKEN Armor Eqmod issue
> --------------------------------
>
>                 Key: DATA-64
>                 URL: http://jira.pcgen.org/browse/DATA-64
>             Project: Data
>          Issue Type: Bug
>          Components: Pathfinder
>    Affects Versions: 5.16.3
>            Reporter: Andrew Maitland
>             Fix For: 5.17.4 (Alpha)
>
>
> Ah right, I found this bug independently.  I worked out how to fix the ACCCHECK
> bit.  I've implemented it in my own data and it works.
> In each armour, you add a bonus that adds the same value as the ACCHECk
> again, but add a PRETYPE:1,Broken to the end.  You also have to modify
> the Mithril special properties to add in their reduction again when they item
> they're added to has the broken type.
> Also, the cost for being broken is currently adding in an extra 0.75 instead
> of taking off 0.25.  I sent a mail about this a couple of days ago
> I've tested all this on my own copy of the data and it works.  I'd have fixed
> it, but I'm a code monkey with no data rank and this is core data we're talking
> about.
> I think we can fix the AC thing as well, but I haven't gotten around to testing
> this yet.
> We put a bonus in the base armour that takes the AC down to half it's
> value with a bonus with a pretype of broken.  So, for instance if the AC is 5,
> you add a bonus that removes 3 when it's broken.  Then in all of the armours
> with an odd value, you add another bonus that adds 1 to AC if the item is
> broken *and* has any of the +1, +3 or +5 enhancements (will need to also
> do +7 and +9 when paizo get around to doing epic).  In each of the +1 to +5
> enhancement EQMODS we add a bonus with a pretype of broken.
> +1 and +2 get a -1 bonus to AC
> +3 and +4 get a -2 bonus to AC
> +5 gets a -3 bonus to AC
> If that all works—and I think it should—you'd only need one broken eqmod and
> all its numbers should work out correctly.
> The way I think
> andrew
> On 20 July 2010 09:52, Martijn Verburg <mar...@gm...> wrote:
> > > Bounce! :)
> > >
> > > On Tue, Jul 13, 2010 at 9:16 AM, Martijn Verburg
> > > <mar...@gm...>wrote:
> > >
> >> >> Bump
> >> >>
> >> >>
> >> >> On Fri, Jul 9, 2010 at 9:58 AM, Martijn Verburg <mar...@gm...>wrote:
> >> >>
> >>> >>> Hi Eric/all,
> >>> >>>
> >>> >>> Sounds like a couple of things should be trackered here, I'm a little
> >>> >>> unsure as to what should go in.  I think a NEWTAG for the EQMod and a DATA
> >>> >>> bug for ITEMCOST being calculated incorrectly?
> >>> >>>
> >>> >>> K
> >>> >>>
> >>> >>> Saxum Caribetum wrote:
> >>>>> >>>> > PCGen 5.17.2, Pathfinder core + bestiary + bonus bestiary
> >>>>> >>>> >
> >>>>> >>>> > when I go to create a Custom Armour item, I am presented, bafflingly,
> >>>>> >>>> > with THREE "Broken" qualities, each of which appears identical, BUT
> >>>>> >>>> > has
> >>>>> >>>> > different effects.
> >>>>> >>>> >
> >>>>> >>>> > taking Chainmail (AC 6, ACCheck -5) as an example, the descriptive
> >>>>> >>>> > text
> >>>>> >>>> > is correct and same for all three
> >>>>> >>>> > "SPROP: AC bonus is halved and AC Check is doubled."
> >>>>> >>>> >
> >>>>> >>>> > Applying the first, gives AC: 5, ACCheck -5, and adds BROKEA1
> >>>>> >>>> > Applying the first, gives AC: 4, ACCheck -5, and adds BROKEA2
> >>>>> >>>> > Applying the first, gives AC: 3, ACCheck -5, and adds BROKEA3
> >>>>> >>>> >
> >>>>> >>>> > picking some other base Armours, it appears each of the 3 BROKEAn
> >>>>> >>>> > subtracts (n) from AC and leaves AC Check unchanged.
> >>>>> >>>> > None of them actually halve the AC, none of them double the AC
> >>>>> >>>> > Check...
> >>>>> >>>> >
> >>>> >>>>
> >>>> >>>> That is because there is currently no way to double the ACCHECK, just
> >>>> >>>> like there is no way to halve the AC.
> >>>> >>>>
> >>>> >>>>
> >>>>> >>>> > I presume this is a plain bug, and maybe even a holdover from Beta or
> >>>>> >>>> > even 3.5?
> >>>>> >>>> >
> >>>> >>>>
> >>>> >>>> The BROKENx EQMods were set up as a partial workaround and probably
> >>>> >>>> need to be removed (commented out) until PCGen can handle that
> >>>> >>>> particular mechanic.
> >>>> >>>>
> >>>> >>>> To do it right we would need a separate EQMod for the AC and ACHECK
> >>>> >>>> adjustments and then would be applied as appropriate based upon the
> >>>> >>>> value of the base armor being modified. As an example, Chainmail, with
> >>>> >>>> its AC 6 and ACCHECK of -5, would have and EQMod applied that reduces
> >>>> >>>> its AC by 3 and an EQMod that increases its ACCHECK by 5. A Broken
> >>>> >>>> Breastplate would require an EQMod that applied an AC bonus of -3 and
> >>>> >>>> an EQMod that rasied the ACCHECK by 4. Each type of armore would
> >>>> >>>> require a different pair of EQMods . . .
> >>>> >>>>
> >>>> >>>> BTW, the COST issue, as you note in another message, IS a bug. The
> >>>> >>>> ITEMCOST should be bonused by a negative BASECOST*.75.
> >>>> >>>>
> >>>> >>>> Maredudd
> >>>> >>>>
> >>>> >>>>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira