[Pcgen-trackers] [ pcgen-Bugs-1907868 ] Row index out of range when remocving an ability

[SourceForge.net <no...@so...>]

Bugs item #1907868, was opened at 2008-03-05 10:58
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1907868&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User Interface
Group:  	  To be fixed For 5.14
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Martijn Verburg (karianna)
Assigned to: Nobody/Anonymous (nobody)
Summary: Row index out of range when remocving an ability

Initial Comment:
AbilitySelectionPanel.update() method attempts to add a row to the underlying table when we're actually removing a row, an Exception is thrown (although no actual harm seems to be done).

We should either not update that table or catch the exception and silently swallow it (logging something in debug mode)

I attempted quickly to only add the row if the selected row was <= to the rowcount, but I think our model of the table has a different row count than the underlying model at that stage (don't take that as gospel though, I only took a real quick look)

-------------------------------------------

10:53:02.697 SEVERE AWT-EventQueue-1 PCGen_Frame1:2820 Uncaught error - ignoring
java.lang.IllegalArgumentException: Row index out of range
	at javax.swing.JTable.boundRow(JTable.java:2049)
	at javax.swing.JTable.addRowSelectionInterval(JTable.java:2099)
	at pcgen.gui.tabs.ability.AbilitySelectionPanel.update(AbilitySelectionPanel.java:666)
	at pcgen.gui.tabs.ability.SelectedAbilityPanel.update(SelectedAbilityPanel.java:162)
	at pcgen.gui.tabs.InfoAbility.updateSelectedModel(InfoAbility.java:588)
	at pcgen.gui.tabs.InfoAbility.removeAbility(InfoAbility.java:753)
	at pcgen.gui.tabs.ability.SelectedAbilityPanel$2.run(SelectedAbilityPanel.java:127)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
	at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:2815)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:273)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:183)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:173)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:168)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:160)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:121)


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1907868&group_id=25576