[Pcgen-trackers] [ pcgen-Bugs-1788307 ] PREVARLT tag is broken

[SourceForge.net <no...@so...>]

Bugs item #1788307, was opened at 2007-09-05 18:44
Message generated for change (Comment added) made by jdempsey
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1788307&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Other
Group:  	  To be fixed For 5.14
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Martijn Verburg (karianna)
>Assigned to: James Dempsey (jdempsey)
Summary: PREVARLT tag is broken

Initial Comment:
Yes please. The PREVARLT tag is definitely broken. I just tested an SA
in a dataset again, and PREVARLT:HonorScore,0 won't pass, while the
equivalent PREVARGT:0,HonorScore does. -- Frank

On 9/3/07, Martijn Verburg <mar...@gm...> wrote:
>
>
>
>
>
>
> Did something need to be trackered here? - K
>
> > TestScore displays as -5 or 5 in the second case.
> >
> > On 8/30/07, James Dempsey <jdempsey@...> wrote:
> > >
> > > Hi Frank,
> > >
> > > If you display these variables, after being bonused, in the console,
> > > what value do they have? Just wondering if it is a bonus problem or a
> > > PREVAR problem.
> > >
> > > Cheers,
> > > James.
> > >
> > > On 30/08/2007, Frank Kliewe <fkliewe@...> wrote:
> > > > 5.13.1 but also to happens in 5.12.1
> > > >
> > > > Using this testing template
> > > > TEST
> > > > DEFINE:TestScore|0
> > > > BONUS:VAR|TestScore|-5
> > > > SA:Test|PREVARLT:TestScore,0
> > > > BONUS:STAT|STR|20|PREVARLT:TestScore,0
> > > >
> > > > SA and BONUS do not appear.
> > > >
> > > > Trying the same with positive values works:
> > > > TEST
> > > > DEFINE:TestScore|0
> > > > BONUS:VAR|TestScore|5
> > > > SA:Test|PREVARGT:TestScore,0
> > > > BONUS:STAT|STR|20|PREVARGT:TestScore,0
> > > >
> > > > Looks like PREVARLT (and PREVARLTEQ) is broken.
> > > >
> > > > Cheerio,
> > > >
> > > > Frank Kliewe
> > > > PCGen Content Silverback
> > > >
> >
>

----------------------------------------------------------------------

>Comment By: James Dempsey (jdempsey)
Date: 2007-10-15 21:28

Message:
Logged In: YES 
user_id=558288
Originator: NO

PREVAR comparisons against negative values were broken. The negative value
was returned as the total number of matches.

Fixed in http://pcgen.svn.sourceforge.net/pcgen/?rev=4287&view=rev

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1788307&group_id=25576