Menu
▾
▴
[Pcgen-trackers] [ pcgen-Feature Requests-1461250 ] Move MW/Magic Type Definitions Used by Eq Customiser to Data
|
From: SourceForge.net <no...@so...> - 2006-08-21 13:01:43
|
Feature Requests item #1461250, was opened at 2006-03-30 21:02 Message generated for change (Comment added) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1461250&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Equipment/WeaponProf Support Group: For 5.12 Status: Closed Resolution: Fixed Priority: 9 Submitted By: James Dempsey (jdempsey) Assigned to: James Dempsey (jdempsey) Summary: Move MW/Magic Type Definitions Used by Eq Customiser to Data Initial Comment: When customising equipment, the program has a list of types it uses to determine if the equipment modifer is a masterwork or magic enhancement and does special name processing as a result. These types are currently hard coded, but should be moved out to the data, most likely to the game mode. See the methods getMagicBonus() and getItemNameFromModifiers() in pcgen.core.Equipment ---------------------------------------------------------------------- >Comment By: James Dempsey (jdempsey) Date: 2006-08-21 23:01 Message: Logged In: YES user_id=558288 That's now been fixed. The slash will only appear between modifiers now. http://svn.sourceforge.net/pcgen/?rev=1335&view=rev Cheers, James. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2006-08-21 14:38 Message: Logged In: YES user_id=886893 I've been testing in order to implement in the data. The only issue I've found is that a slash is included with the name. Example FORMATCAT:MIDDLE in the +1 EQMOD creates this: Sword +1/ (Short) and Dagger =1/ I think we want the space after but not the slash. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2006-08-19 22:06 Message: Logged In: YES user_id=558288 Implemented. Code changes in: http://svn.sourceforge.net/pcgen/?rev=1323&view=rev Doc changes in: http://svn.sourceforge.net/pcgen/?rev=1324&view=rev ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2006-08-19 14:42 Message: Logged In: YES user_id=558288 Updated tag proposal discussed at https://sourceforge.net/support/tracker.php?aid=1489469 has been approved. New syntax is *TagName: * FORMATCAT:x *Variables Used:* x: FRONT, MIDDLE, or PARENS *What it does:* Defines how the equipment modifier's name will be displayed when an equipment item name is being automatically generated. The valid values and their actions are listed below: * FRONT - The eqmod name appears before the base equipment item name. * MIDDLE - The eqmod name appears after the base equipment item name but before the parenthesis. * PARENS - (Default) The eqmod name appears in brackets after the base equipment item name. *Example:* Masterwork[tab]FORMATCAT:PARENS[tab]NAMEOPT:TEXT=MW when applied to a battleaxe would give battleaxe (MW) MAGIC_PLUS_1[tab]FORMATCAT:FRONT[tab]NAMEOPT:TEXT=+1 when applied to a battleaxe would give +1 battleaxe MAGIC_PLUS_1[tab]FORMATCAT:MIDDLE[tab]NAMEOPT:TEXT=+1 when applied to a battleaxe would give battleaxe +1 ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2006-06-22 11:44 Message: Logged In: YES user_id=558288 Pushed back to 5.12 after consultation with Devon and Frank. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2006-05-07 11:03 Message: Logged In: YES user_id=558288 Tag proposal posted at http://groups.yahoo.com/group/pcgen_experimental/message/5290 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1461250&group_id=25576 |