[Pcgen-trackers] [ pcgen-Bugs-1227266 ] MSRD: Exotic Melee Proficiency not working.

[SourceForge.net <no...@so...>]

Bugs item #1227266, was opened at 2005-06-24 21:09
Message generated for change (Comment added) made by nuance
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1227266&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Feat Support
Group: 5.8.0 Stable
Status: Open
Resolution: None
Priority: 9
Submitted By: JadeSteele (jadesteele)
Assigned to: Martijn Verburg (karianna)
Summary: MSRD: Exotic Melee Proficiency not working.

Initial Comment:
In the MSRD when trying to use Exotic Melee Proficiency
(specifically Three-Section Staff but it does the same
thing with other weapons as well), the selected weapon
does not register as proficient in the inventory tab.  

After allocating the feat then saving and reloading, an
error pops up saying the character is no longer
proficient with "LIST".  The feat dissapears and the
feat point is not reallocated as usable (the character
effectively loses one feat).

----------------------------------------------------------------------

>Comment By: Andrew Wilson (nuance)
Date: 2005-09-20 15:21

Message:
Logged In: YES 
user_id=41667

Do we really need a code fix for this?

We could call the proficiency "ExoticMelee Weapon Proficiency" 
give it an outputname of "Exotic Melee Weapon Proficiency" and
then add the type exoticmelee to the types.

Does that not fix it without hacking the TYPE code so that
it returns types that aren't there.

I haven't tested this, I'm just asking.  This is already a mess
because it's getting meta information from the name.  That
put nasty constraints on what you can call things.  I really
think the long term solution to this lies in making the
weapon proficiencies a specific category of Ability, or adding
a new Tag that marks it as a weapon proficiency, or something
else clever. 

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2005-09-20 13:35

Message:
Logged In: YES 
user_id=252169

Thanks James, I see it now, hmm, that's a nasty one, it does
a getType() on the WeaponProf and gets EXOTIC back.  I'll
have to try and fiddle with that so it returns EXOTIC MELEE
and EXOTIC FIREARM as well, this will be another day or so - K

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2005-09-20 12:11

Message:
Logged In: YES 
user_id=558288

The code expects a specific format feat name. This is
[ProfType] Weapon Proficiency. So if you rename the feat to
Exotic Weapon Proficiency, it all works perfectly. See
PlayerCharacter.addWeaponProfToList() at about line 12165

Cheers,
James.

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2005-09-20 10:51

Message:
Logged In: YES 
user_id=252169

Quite a bit of weirdness going on here.  

1.)  When adding the weapon prof, it seems to add it to the
weapon prof list of the PC OK, and it sets the dirty flag to
true, yet the old Abilities tab, doesn't have the weapon
listed in there.  Some how is dirty is not taking affect?

2.)  I still see a difference in the way that Exotic Weapon
Profs are coded in the list files, in MSRD there is a
AUTO:WEAPONPROF|LIST attached to the Exotic Melee Weapon
Proficiency.  That does not exist in RSRD, however removing
that part did not fix the problem.  Subsequently reading the
docs and checking the ability tab AUTO:WEAPONPROF|LIST
basically adds a Weapon Prof called LIST, so I think this
should still be removed.

3.)  The pcg file definitely has the three-section staff,
with the line:
FEAT:Exotic Melee Weapon Proficiency|APPLIEDTO:Three-Section
Staff|TYPE:BATTLEMIND.GENERAL.SHADOWSLAYER.SOLDIER.MARTIALARTIST|DESC:Choose
one exotic melee weapon from. The character is proficient
with that melee weapon in combat

4.)  As a complete side note.  The code base tends to refer
to things that end in "Weapon Proficiency", not
"Proficiency", so other feats that give Weapon Profs may be
acting strangely.

Hmm, that's about as far as I'm gonig to get today - K

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-09-16 22:58

Message:
Logged In: YES 
user_id=208239

I've adjusted the file in MSRD to follow RSRD.  Doesn't
change the lack of proficiency display on inventory tab.

Code bug definitely.  I still think it is linked to having
"Exotic" and "ExoticFirearms" as proficiencies and the code
not really checking fully.

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-09-12 08:08

Message:
Logged In: YES 
user_id=208239

Hm....

Crap, I hate the CHOOSEr.  I'll look at it from a data 
perspective first.  I still think there might be an code issue.

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2005-09-08 15:53

Message:
Logged In: YES 
user_id=252169

Hi Tir, ignore my comment below (I think I got it wrong). 
_But_ the Exotic Weapon Prof in MRSD and RSRD are coded
slightly differently, surely they should be coded in the
same way? - K

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2005-09-08 15:45

Message:
Logged In: YES 
user_id=252169

Exotic Firearms prof does _not_ work.  I will look @ the
code later, I assume it should work similar to exotic wepaon
prof in RSRD in that it gives a hidden proficiency - K

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-08-24 13:10

Message:
Logged In: YES 
user_id=886893

flaging for 5.8.1

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-08-16 02:24

Message:
Logged In: YES 
user_id=886893

I've been through the LST looking for a data reason this is broken 
but I can't find one. This feat is coded exactly like the Exotic 
Firearms Proficiency feat and that one works

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1227266&group_id=25576