pcbsd-developer

[Pcbsd-developer] An ask on PCBSD Usermanager.

[Matteo N. <mat...@da...>]

Hi, i see in source code of usermanagerback.cpp

fullnameRegExp.setPattern("([a-z]*[A-Z]*[0-9]*\\s*)+");

But, into:

/usr/src/usr.sbin/pw/pw_user.c, i see:

char    *
pw_checkname(u_char *name, int gecos)
{
        *****************
        *****************
        if (gecos) {
                /* See if the name is valid as a gecos (comment) field. */
                badchars = ":!@";
                showtype = "gecos field";

the only 3 character not allowed to be in Fullname are:

badchars = ":!@";

My ask is: Why usermanager of PCBSD is more restrictive than
userland FreeBSD binaries, that add/remove user from the system?

This is a problem, because if you add an user with useradd, you
can have FullName like "Pippo &", but if you try to edit this user
with PCBSDUserManager, when you try to save changes (without
change the FullName), it gives you an error on "Pippo &".

Why not use the same badchars of pw_user.c instead of a
regular expression?

Bye.

Re: [Pcbsd-developer] An ask on PCBSD Usermanager.

[Tim M. <ti...@pc...>]

Hi Matteo,

Thanks for the info, you make an excellent point.

I'll see that this gets fixed for the final version.

Regards,

Tim

On Wednesday 19 April 2006 12:50, Matteo Niccoli wrote:
> Hi, i see in source code of usermanagerback.cpp
>
> fullnameRegExp.setPattern("([a-z]*[A-Z]*[0-9]*\\s*)+");
>
> But, into:
>
> /usr/src/usr.sbin/pw/pw_user.c, i see:
>
> char    *
> pw_checkname(u_char *name, int gecos)
> {
>         *****************
>         *****************
>         if (gecos) {
>                 /* See if the name is valid as a gecos (comment) field. */
>                 badchars = ":!@";
>                 showtype = "gecos field";
>
> the only 3 character not allowed to be in Fullname are:
>
> badchars = ":!@";
>
> My ask is: Why usermanager of PCBSD is more restrictive than
> userland FreeBSD binaries, that add/remove user from the system?
>
> This is a problem, because if you add an user with useradd, you
> can have FullName like "Pippo &", but if you try to edit this user
> with PCBSDUserManager, when you try to save changes (without
> change the FullName), it gives you an error on "Pippo &".
>
> Why not use the same badchars of pw_user.c instead of a
> regular expression?
>
> Bye.
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live
> webcast and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> PCBSD-Developer mailing list
> PCB...@li...
> https://lists.sourceforge.net/lists/listinfo/pcbsd-developer

-- 
Tim McCormick
PC-BSD System Developer
ti...@pc...