From: gpleda.org c. r. <69...@bu...> - 2011-08-26 02:11:04
|
Bug was fixed by a commit git master commit 2948179e8c693f2ca8666e0ca212198254e76285 http://git.gpleda.org/?p=pcb.git;a=commit;h=2948179e8c693f2ca8666e0ca212198254e76285 commit 2948179e8c693f2ca8666e0ca212198254e76285 Author: Andrew Poelstra <as...@sf...> Commit: Andrew Poelstra <as...@sf...> Use GtkPcbLayerSelector in gtk GUI Closes-bug: lp-699482 ** Changed in: pcb Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of PCB Bug Team, which is subscribed to pcb. https://bugs.launchpad.net/bugs/699482 Title: Fix sf-2924962 and other issues with layer selection Status in PCB: Printed Circuit Board CAD package: Fix Committed Bug description: In general there was a lack of consistency in the behavior when changing the visibility of layers using the buttons and menu. This fixes both the hang in the bug report (lp:699308), and many other small issues. The code attempted to make it so that the active layer was always visible, but failed in a few places, such as when the silk or rats layers were activated while hidden or hidden while active, or when the last layer group was active and hidden, it remained active. There was also issues when the active layer was hidden using the menus. This patch fixes all of that. This patch allows the active layer to become the silk or rats layer if no copper layer is visible. It was necessary to add an additional flag to ChangeGroupVisibility() to indicate if the hid should be notified via the LayersChanged action. This was causing problem when the menu was used to hide the active layer, an extra LayersChanged call was scheduling a ghid_menu_cb which reverted the change to the layer visibility. In generally this was causing also just causing a lot of extra calls to update the gui when the gui itself was calling ChangeGroupVisibility and was going to be updating itself later on anyway. For the most part I set the new flag to be true (to keep the old behavior) except when it was causing problems and definitely correct to set it to false. To manage notifications about this bug go to: https://bugs.launchpad.net/pcb/+bug/699482/+subscriptions |