pbbuttons-users

display autoadjust and blank screen

[Yves-Alexis P. <co...@co...>]

Hi there,

i'd like to know if it's a bug (or a feature) that I can't blank the
screen with pbbuttonsd when using Display Autoadjust=3Dyes.

If it's off, I can set the brightness from 15 to 0. If it's on, I can't
go below 1. I've reported this as a bug in debian bts [1] but no news.

[0]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D345314
--=20
Yves-Alexis Perez

Re: display autoadjust and blank screen

[Matthias G. <mat...@us...>]

On Wed, 22 Feb 2006 09:38:43 +0100
Yves-Alexis Perez <co...@co...> wrote:

> Hi there,
> 
> i'd like to know if it's a bug (or a feature) that I can't blank the
> screen with pbbuttonsd when using Display Autoadjust=yes.
> 
> If it's off, I can set the brightness from 15 to 0. If it's on, I can't
> go below 1. I've reported this as a bug in debian bts [1] but no news.

I'm sorry to hear that but debian bts is for debian only. I don't read
the debian bugtracker on a regular basis.

Back to your question. It is not a bug. The responsible code is in
module_display, function display_keyboard(), first part of the
switch(changed){} statement, line 315-316.

When automatic mode is active, the brightness keys generate an offset
that will be added to the value from the automatic brightness
controller. This offset will be clipped if the overall brightness
level is out of range. The limits are 1 or BRIGHTNESS_MAX.

You might change the lower limit to 0 to be able to switch off your
display completely also in automatic mode. But keep in mind that this
value still depends on the ambient light level. That means if the
environment goes darker, the backlight might be switched on again.

I haven't got much feedback on this feature if the behaviour is ok
or not. Nobody complained so far but that means nearly nothing. If you
have a certain vision on how the behaviour should be, please tell me.
Possibly it is a general benefit for the function.

  Best Regards
    Matthias

Re: display autoadjust and blank screen

[Yves-Alexis P. <co...@co...>]

On Wed, 2006-02-22 at 21:39 +0100, Matthias Grimm wrote:
> On Wed, 22 Feb 2006 09:38:43 +0100
> Yves-Alexis Perez <co...@co...> wrote:
>=20
> > Hi there,
> >=20
> > i'd like to know if it's a bug (or a feature) that I can't blank the
> > screen with pbbuttonsd when using Display Autoadjust=3Dyes.
> >=20
> > If it's off, I can set the brightness from 15 to 0. If it's on, I can't
> > go below 1. I've reported this as a bug in debian bts [1] but no news.
>=20
> I'm sorry to hear that but debian bts is for debian only. I don't read
> the debian bugtracker on a regular basis.

Well, the maitainer could be overbooked :)
>=20
> Back to your question. It is not a bug. The responsible code is in
> module_display, function display_keyboard(), first part of the
> switch(changed){} statement, line 315-316.
>=20
> When automatic mode is active, the brightness keys generate an offset
> that will be added to the value from the automatic brightness
> controller. This offset will be clipped if the overall brightness
> level is out of range. The limits are 1 or BRIGHTNESS_MAX.

ok

>=20
> You might change the lower limit to 0 to be able to switch off your
> display completely also in automatic mode. But keep in mind that this
> value still depends on the ambient light level. That means if the
> environment goes darker, the backlight might be switched on again.

hmh, ok, but that won't do the trick :/

>=20
> I haven't got much feedback on this feature if the behaviour is ok
> or not. Nobody complained so far but that means nearly nothing. If you
> have a certain vision on how the behaviour should be, please tell me.
> Possibly it is a general benefit for the function.

I don't know the real behavior in OSX, but when using automatic adjust
you play on offset as well I guess. The difference is, when you switch
off the screen, setting brightness=3D0, it keeps this value even if light
goes darker.

I guess brightness=3D0 could be "forced", whatever the autoadjust switch
state is.
>=20
>   Best Regards
>     Matthias

Thanks for the reply :)

Regards,
--=20
Yves-Alexis Perez

Re: display autoadjust and blank screen

[Yves-Alexis P. <co...@co...>]

On Thu, 2006-02-23 at 00:17 +0100, Yves-Alexis Perez wrote:
> On Wed, 2006-02-22 at 21:39 +0100, Matthias Grimm wrote:
> > Back to your question. It is not a bug. The responsible code is in
> > module_display, function display_keyboard(), first part of the
> > switch(changed){} statement, line 315-316.
> > 
> > When automatic mode is active, the brightness keys generate an offset
> > that will be added to the value from the automatic brightness
> > controller. This offset will be clipped if the overall brightness
> > level is out of range. The limits are 1 or BRIGHTNESS_MAX.
> 
> ok
> 
> > 
> > You might change the lower limit to 0 to be able to switch off your
> > display completely also in automatic mode. But keep in mind that this
> > value still depends on the ambient light level. That means if the
> > environment goes darker, the backlight might be switched on again.
> 

Ok, so, attached is a (dirty) patch which enable switching off the LCD
while in automatic adjust mode. In order not to depends on the ambient
light leve i've set the status to OFF, which works but may not be really
clean.


-- 
Yves-Alexis Perez

Re: display autoadjust and blank screen

[Kristian B. <kb...@op...>]

On Thu, 2006-02-23 at 15:42 +0100, Yves-Alexis Perez wrote:
> On Thu, 2006-02-23 at 00:17 +0100, Yves-Alexis Perez wrote:
> > On Wed, 2006-02-22 at 21:39 +0100, Matthias Grimm wrote:
> > > Back to your question. It is not a bug. The responsible code is in
> > > module_display, function display_keyboard(), first part of the
> > > switch(changed){} statement, line 315-316.
> > > 
> > > When automatic mode is active, the brightness keys generate an offset
> > > that will be added to the value from the automatic brightness
> > > controller. This offset will be clipped if the overall brightness
> > > level is out of range. The limits are 1 or BRIGHTNESS_MAX.
> > 
> > ok
> > 
> > > 
> > > You might change the lower limit to 0 to be able to switch off your
> > > display completely also in automatic mode. But keep in mind that this
> > > value still depends on the ambient light level. That means if the
> > > environment goes darker, the backlight might be switched on again.
> > 
> 
> Ok, so, attached is a (dirty) patch which enable switching off the LCD
> while in automatic adjust mode. In order not to depends on the ambient
> light leve i've set the status to OFF, which works but may not be really
> clean.

This might be a bit late, but I made this script a while ago to handle
this. I do agree that pbbuttonsd should handle it with the buttons duh.

#!/bin/sh

# Do not autoadjust the lcd while blanking the screen.
pbbcmd config LCDAUTOADJUST 0

# It take some time to set the brightness to 0, wait until its done.
until [ "`pbbcmd query LCDBRIGHTNESS | sed -e 's/ //g'`" == "0" ]
do
    pbbcmd config LCDBRIGHTNESS 0
done

# Then check at regular interval to see if the user changed the brightness.
while [ "`pbbcmd query LCDBRIGHTNESS | sed -e 's/ //g'`" == "0" ]
do
    sleep 5
done

# Finish by resetting the autoadjust.
pbbcmd config LCDAUTOADJUST 1

--
Kristian