manual lcd off reset by return from idle

[Matthias G. <mat...@us...>]

Hi Tim,

I saw you bug report on sourceforge.net, unfortunately after I
published the new release :-/. Nevertheless I would like to comment it.

> - when panel birghtness is > 0, save before dimming/suspending lcd,
>   restore after return from idle (implemented)
> - when panel brightness is == 0, save before dimming/suspending lcd,
>   restore lcd to brightness of 0 after return from idle (not possible)
>
> I do think that this is a bug. The LCD should not turn on due to user
> interaction if the LCD was turned off by the user prior to idling the
> machine. If you disagree, please consider providing a pbbuttonsd option
> for this purpose.

This behaviour is definitely not a bug; it's a design decision. I
thought that it would be irritating that the display once switched to
darkness by hand will stay dark forever. But this is my personal
opinion and you are the first one who responded to this feature.

I would like to open a discussion if we should revise the design decision
on pbb...@li....

In the meantime you could help yourself by editing the source of pbbuttonsd.
In module_display.c, function display_change_brightness() you will find a
switch - case statement. In the case section OP_DIM_RECOVER comment the
following lines out:
   if (base->lcdlight.target == LCD_BRIGHTNESS_OFF)
       base->lcdlight.target = LCD_BRIGHTNESS_MIN;

After this change pbbuttonsd should do what you want.

 Best regards
   Matthias