Re: Question about CFLAGS handling in configure.in

[Matthias G. <mat...@us...>]

On Wed, 28 Sep 2005 19:24:09 +0200
Frank Lichtenheld <dj...@de...> wrote:

> In configure.in of gtkpbbuttonsd (and probably the others, too, didn't
> check) you use the following snippet:
> 
> CFLAGS=
> dnl Use -Wall if we have gcc.
> changequote(,)dnl
> if test "x$GCC" = "xyes"; then
>   case " $CFLAGS " in
>   *[\ \ ]-Wall[\ \      ]*) ;;
>   *) CFLAGS="$CFLAGS -Wall" ;;
>   esac
> fi
> changequote([,])dnl
> 
> which is bit "suboptimal", since it deletes all previous changes
> to CFLAGS, especially such given in the configure commandline or
> as enviroment variables.
> 
> Is there a good reason to do this? It seems you use this only to
> filter out "-g" from CFLAGS?

This code is a relict from the very beginning of pbbuttonsd development.
I used the autotools files from glade as base for my own. This sippet
was part of the glade files and was never questioned.

Any suggestions to replace it?

 Best Regards
   Matthias