#1598 Intermediate backup, incremental number does not rollover from 999 to 000/001

[Mitch Ames]

With Password Safe 64-bit v3.66 (or 3.65.1), on Windows 7 or Windows 10 ...
In Options, Backup, enable Intermediate Backups, Base=Database name, Suffix=Incremental Number
Edit the database and save to create incremental backup(s). Repeat 999 times (or just manually copy the file to basename_999.ibak)
Edit the database and save.
Expected behaviour: create basename_001.ibak (or 000).
Actual behaviour: creates basename_yyyymmdd_hhmmss.ibak, and Options, Backup, is changed to that suffix.

I'm sure the rollover used to work in an earlier version - I do remember it rolling over correctly some time in the past, but I can't remember how long ago that was. (If necessary, I could probably go through my archives and find out approximately when it last worked, and approximately what version I had at the time.)

[Rony Shapiro]

This is working as designed. See https://sourceforge.net/p/passwordsafe/bugs/1547/

[Mitch Ames]

See https://sourceforge.net/p/passwordsafe/bugs/1547/

I don't have access to that page - it says "Forbidden. Sorry, the permissions for this page don't allow you to access it."

[Rony Shapiro]

Fixed the access to BR1547, you should be able to read it now.

[Mitch Ames]

Fixed the access to BR1547, you should be able to read it now.

Thanks, I can read it now, but I don't understand. Is "working as designed" here because you disabled the rollover (switching to date_time) to fix bug 1547?
I just tested with v3.56 and the rollover from 999 to 001 works as I expected (with 5 backup files), then stops working (ie switches to date_time) when I repeat the test with v3.57.

Perhaps - per bug 1547 - there was/is a problem when Max backups is 999 (an obvious edge-case), but it was working fine when Max backups is 5.

It's not a huge problem (I can manually rename the 99x files to 00x and restore my config setting) but it would be nice to have the rollover functionality back (even if it only gets invoked every few years). Possible fix would be to limit the max backups to 998 or fewer. (As you said, if someone wants that many backups, date_time will do it.)

The main reason I prefer numbered backups is because:
- there is more than one
- Password Safe automatically deletes the older files, so I don't have to do it manually.