#1055 OK button greys out when clicking Apply

v1.0_(example)
closed
5
2013-01-09
2012-08-12
No

A really annoying bug, when editing an entry, and you click on apply, the OK button greys out.

I keep hoping that your new releases fix the issue but it's been persistent for a long time, I am surprised nobody has mentioned it, this should be a super quick fix.

PS. Thanks for doing a great job, keep it up

Note.. I still am waiting until you add a keep on top option once one copies the userid, so that the window is still open to copy the password, I am using two monitors now so it's not much of a problem, but it would be an AWESOME feature to add (and I'm sure it wouldn't take much either).

Thanks again!

Discussion

  • Bharat

    Bharat - 2012-08-15

    Hi I would like to look at this. Please assign this to me.

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-16

    The Burkster,

    Well, it's just being consistent, really. The idea is that OK and Apply are active if and only if there's been a change to the entry. Once you click on Apply,the change has been saved, so the entry's now logically 'unmodified' again.

    I can understand that this is confusing, though. Perhaps indicating that the entry's modified in another manner, such as an asterisk (*) in the title bar, would be more friendly?

    What do you think?

    Bharat: Let's understand the problem and desired solution first.

    Rony

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-16

    The Burkster: Regarding your 'keep on top' request - isn't the feature in "Manage->Options->Display->Always keep Password Safe on top" sufficient for your needs? If not, please explain the scenario in detail.

    Rony

     
  • The Burkster

    The Burkster - 2012-08-16

    Rony..

    The issue with the OK and Apply button is that in other programs when you click apply the ok button is still usable. From my experience the OK button applies the changes and closes the window and the apply button applies the changes but keeps the window open - thus allowing you to click OK to close the window when you are ready. Currently when the OK button is greyed out you need to x out the window to close.

     
  • The Burkster

    The Burkster - 2012-08-16

    Regarding the keep on top request, forcing the app to stay on top via option is not the same as having it stay on top temporarily with an option that you could enable which

    • when copying the username would keep the progam on top
    • once the password is copied the program would then no longer stay on top

    This way you can go on about your business and the program will go in the background as soon as you leave the app to paste your password.

    make sense?

     
  • ShivaKandi

    ShivaKandi - 2012-08-17

    Hey Rony
    Like the therealburkster said, there has to be a difference between apply and ok button. Ok button usually saves the final changes and closes the windows, whereas apply button saves changes while the window being still open, so kind of a preview for a user of how the changes looks like. So he further modifies till he is satisfied and then make final change and close. For the same, ok button has to be available till the final move. Thus, I am completely of opinion that ok button should be there even if apply button is pushed.
    In addition, I would further like to add that I'd like to fix the bug, if it is decided that the above situation needs to be fixed.

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-18

    ShivaKandi: Please change the behavior of OK/Cancel/Apply as follows:
    1. OK Apply and Cancel are always enabled when the entry is editable (that is, the database is not open r-o and the entry is not marked as 'protected')
    2. If an entry is modified, then the title of the entry gets a ' ' added to the right.
    3. If 'Apply' is clicked on a modified entry, then in addition to what's currently being done, the '
    ' is removed from the title bar.

    therealburkster: Thanks for spelling the 'temporary keep on top' for me. Could you enter a separate Feature Request for this, so that we can better track it. It's a nice idea, definitely worth trying out. I'd rather make it the standard behavior when a username's selected, rather than add yet another configurable behavior, at least for starters...

    Thanks,

    Rony

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-23

    Fixed in revision 5039, based on shivak7's patch.

     
  • The Burkster

    The Burkster - 2012-08-23

    added separate Feature Request as per Ronys

    Thank you for everything!!!

     
  • Rony Shapiro

    Rony Shapiro - 2013-01-09
    • status: pending --> closed
    • milestone: --> v1.0_(example)
     

Log in to post a comment.