#72 crashes with UnimplementedConversionException

[Rob Gardner]

v6.19.0 on android 9, Samsung A50, after entering password for database, app crashes with the following stack trace:
org.pwsafe.lib.exception.UnimplementedConversionException at org.pwsafe.lib.file.PwsRecordV2.loadRecord(PwsRecordV2.java:266) at org.pwsafe.lib.file.PwsRecord.<init>(PwsRecord.java:211) at org.pwsafe.lib.file.PwsRecordV2.<init>(PwsRecordV2.java:157) at org.pwsafe.lib.file.PwsRecord.read(PwsRecord.java:392) at org.pwsafe.lib.file.PwsFile.readAll(PwsFile.java:502) at org.pwsafe.lib.file.PwsFileFactory.loadFromStorage(PwsFileFactory.java:217) at com.jefftharris.passwdsafe.file.PasswdFileUri.load(PasswdFileUri.java:255) at com.jefftharris.passwdsafe.file.PasswdFileData.load(PasswdFileData.java:98) at com.jefftharris.passwdsafe.PasswdSafeOpenFileFragment$OpenTask.doInBackground(PasswdSafeOpenFileFragment.java:842) at com.jefftharris.passwdsafe.PasswdSafeOpenFileFragment$OpenTask.doInBackground(PasswdSafeOpenFileFragment.java:814) at com.jefftharris.passwdsafe.lib.ManagedTask$Task.doInBackground(ManagedTask.java:130) at com.jefftharris.passwdsafe.lib.ManagedTask$Task.doInBackground(ManagedTask.java:98) at android.os.AsyncTask$2.call(AsyncTask.java:333) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:764)</init></init>

Database has 410 entries. Perhaps you could catch the UnimplementedConversionException and print the uuid of the offending record or something? This might help in tracking down what the problem is. BTW I've got an older copy of the database that does not cause the crash, so it must be something I've added/changed in the past 8 years.

[Jeff Harris]

Are you using Password Gorilla to edit the file? It seems to add some extra fields (URL and/or autotype iirc) that aren't part of a normal v2 database. You should be able to convert the file to the v3 format which officially supports the fields.
If you have a test file with the error, please attach it so I can look further.

[Rob Gardner]

I am using Password Gorilla. In preferences->defaults I already had the box checked for "use password safe 3 format" but this evidently is not sufficient. Under the security->preferences menu I just found another check box, "use password safe 3 format" and when I checked this box, it actually did save the database in v3 format. And this did eliminate the crash when opening the database on android. So case closed, thank you for the help.

[Jeff Harris]

If you have a chance to create a test file with the error, I can look at the issue with the v2 fields. Even though they are non-standard, I may be able to preserve them.

[Rob Gardner]

OK I'll see if I can create a small example that shows the problem.