Re: [Pasdoc-main] PasDoc nested types

[Michalis K. <mic...@gm...>]

Hi,

I allow myself to reply to the public pasdoc-main list, as this is also
a reply to the "[Pasdoc-main] Nested types" thread. I hope it's OK :)

Arno Garrels wrote:
[...]
> A design change as DoDi suggested should be considered
> sooner or later. 

I'll welcome a design change. Just make it as gradually as reasonably
possible, and fix the eventual bugs along the way :) Your current patch
is a good first step --- apply it, fix bugs, and then move further :)

>So before I risk to have to revert my changes in svn
> I send you my patch for a brief review of the parser changes, the other
> stuff should be 100% o.k.. If you think it is o.k. I'll commit that
> work. 
> 

On a quick glance, the code looks OK, I have no objections. There are
however two failures on the test suite (html output), be prepared to fix
them (before committing, or you can commit current patch and fix them
afterwards --- we can live with these two failures for a short time :)

- ok_abstract_sealed fails: looks like "var" keyword is changed into
"internal" in the output.

- ok_record_case_parsing and ok_record_with_case fail with "Fatal Error:
Invalid type cast" and do not generate any output.

Michalis