Re: [Parser-devel] Parser is ready

[Jinesh K J <jin...@gm...>]

On 10/17/06, Noam Postavsky <npo...@uw...> wrote:
> "Jinesh K J" <jin...@gm...> writes:
>
> > I didn't really understand what you meant by 'out if date'; which is
> > the updated one? So, you wish to work only on your functions(in
> > branches/np/) or the entire trunk/ ?
>
> 'out of date' means not updated, or old. Basically I want to work on
> the version of my functions from the trunk/ because they are the
> updated ones, but I want to use the testcases from branches/np/
Then what you may do is:

svn copy trunk/file.c branches/np/
svn copy trunk/transform.c branches/np/

file.c contains puttoken() whereas the rest are in transform.c

You may then change the branches/np/Makefile to use these files
instead of token.c and comment.c. After each satisfactory
modifications you make, we will merge these files back into the
trunk/.

>
> > Also, kindly see whether your code can be made more readable - coz
> > that's very important as far as collaborative efforts are concerned.
>
> I would like to make my code more readable, but the problem is that it
> looks readable to me because I wrote it. I would greatly appreciate it
> if you could tell me what makes it less readable and/or ways to make
> it more readable.
Yes. I'll try to find out what all things could be done.

>
> >>
> >> I was also wondering if there is an important reason to use char *
> >> instead of const char * in my functions. I always though that a
> >> function should declare char pointers const if it doesn't modify the
> >> string...
> >>
> > Yes. you're right. I just changed them to char * to remove a few
> > warnings (I dont really remember where they were). But we can surely
> > re-introduce the 'const' before the next release.
> >
> > Also, in the mean time, I'm doing some serious rework over the
> > transform() function in the transform.c.
>
> Actually after I sent that, I thought of a reason to keep it as char*:
> it would allow changing the implementation to one that modifies the
> string. I guess we should figure out if transform() requires that the
> string remains constant, after you finish your reworking of course.

My work is now almost over - All my planned tasks have been completed.
Re-introduction of 'const' can be done along this process. Let me know
when you want the changes(in file.c and transform.c) to be merged.

Regards,
Jinesh.