Re: [Parser-devel] Parser is ready
Status: Beta
Brought to you by:
jineshkj
From: Jinesh K J <jin...@gm...> - 2006-10-17 04:04:39
|
On 10/17/06, Noam Postavsky <npo...@uw...> wrote: > "Jinesh K J" <jin...@gm...> writes: > > > If you think you can make more optimisations over the stuff, then we > > can make a different branch for you to work on. After your tweaks, we > > can merge it to the main trunk. What do you say? > > Yes, I want to do a few things, but already the old branch with the > test cases I was using is slightly out of date. So is there an > easy way to bring it up to date? I didn't really understand what you meant by 'out if date'; which is the updated one? So, you wish to work only on your functions(in branches/np/) or the entire trunk/ ? Also, kindly see whether your code can be made more readable - coz that's very important as far as collaborative efforts are concerned. > > I was also wondering if there is an important reason to use char * > instead of const char * in my functions. I always though that a > function should declare char pointers const if it doesn't modify the > string... > Yes. you're right. I just changed them to char * to remove a few warnings (I dont really remember where they were). But we can surely re-introduce the 'const' before the next release. Also, in the mean time, I'm doing some serious rework over the transform() function in the transform.c. Jinesh. |