Re: [Parser-devel] Parser is ready

[Jinesh K J <jin...@gm...>]

On 10/14/06, Noam Postavsky <npo...@uw...> wrote:
> "Jinesh K J" <jin...@gm...> writes:
>
> > I'm resending the mail - I believe your mail server did not accept the
> > original one as given below:
> Yes, I had a core dump file filling my quota.
>
> > On 10/12/06, Jinesh K J <jin...@gm...> wrote:
> >> Hi Noam,
> >>
> >> So in the end, the parser library is ready to go. You might wanna go
> >> to trunk/ and modify some stuff yourself. May be you wanna add your
> >> name into the MAINTAINERS file or something else too.
> >>
> >> One thing that you've not yet done is the documentation of the new
> >> functions. If you like to do it, may be you can start learning
> >> Doxygen. Let me know if you want me do it for you - if you are not
> >> comfortable with code documentation.
>
> I'll see if I can handle it, doesn't look too different from TeX.
Its very simple. You can see the existing code for example.

>
> >> Since all the functionalities are in place you might also wanna make
> >> it (new functions) more modularised. Its up to you.
>
> I guess there is a bit of duplication with copy stuff up to char X...
>
> Do you think it would be worth making a gettoken_noalloc? It would
> save one memory allocation in getgroup.
It doesn't matter(atleast for the time being), even if we do
unnecessary memory allocations - what do need is to make sure that
there is no memory leak. We all know that getgroup() returns an
malloc'ed string upon success - but if gettoken() is called by
getgtroup(), then its the responsibility of getgroup() to free() it
before returning. If such things are made sure then I believe there's
nothing to worry.

If you think you can make more optimisations over the stuff, then we
can make a different branch for you to work on. After your tweaks, we
can merge it to the main trunk. What do you say?

PS : I have a major overhaul for the library in my mind - the API's
will change then. But your code will still remain the same(coz that's
the core) - so you can do your tweaking without affecting my work !

>
> >> I'm waiting for your reply so that the next release can be made. Don't
> >> worry, I'm not in a hurry.
> >>
> >> Regards,
> >>
> >> Jinesh.
> >>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Parser-devel mailing list
> Par...@li...
> https://lists.sourceforge.net/lists/listinfo/parser-devel
>