Re: [Parser-devel] [token.c] A new functionality
Status: Beta
Brought to you by:
jineshkj
From: Noam P. <npo...@uw...> - 2006-10-10 03:56:50
|
Jinesh K J wrote: > So, one more functional change(I very well hope so) is all that we > need to merge these changes to the main tree. A behavioural change > with gettoken is needed. I don't really know how hard it would be for > you to make this change. It is as follows: > > ======begin======== > > char *gettoken(char *str, char **kv, char **end); > > str - input string > *end - the next character after our extracted token > *kv - the value part of our token(if its a key/value pair) - malloc'ed > > Returns -> the key/value part - malloc'ed > > ======end========== > I think by now our requirements are almost clear and complete. What is > your opinion? Any suggestions? > > > Jinesh. I feel like this it too much functionality to be putting into gettoken. It's true I don't really have much of the big picture, ie how these functions are going to be used in the library, but I think that splitting tokens should be a separate task from interpreting those tokens. That's what it looks like to me, anyway. Noam |