Re: [Parser-devel] [token.c] A new functionality
Status: Beta
Brought to you by:
jineshkj
From: Noam P. <npo...@uw...> - 2006-10-06 12:28:13
|
Jinesh K J wrote: > Both the functions are working fine. While gettoken is perfect there's > a flaw with cutcomment. I think I didn't take much time to explain > what 'str' can contain. 'str' contains a line inside the configuration > file. For example: > > server=192.168.0.1 port=2183 # This is our server > > A line can also contain quoted values like: > > server="192.168.0.1" port="2183" # This is our server > > In any case, the '#' inside the quote should be counted as the start OK, I think you mean should NOT be counted, that's what the test cases seem to indicate. > of the comment. I've added a few test cases for that too. All the > rules for quotes that we've followed till now applies here also. I > hope now things are clear. What do you say? > > Jinesh. I've changed the function to pass the test cases, I think this is what you meant, if not, more thorough explanation is needed. Noam |