Re: [Parseperl-discuss] Spelling: seperator vs. separator

[Adam K. <ad...@ph...>]

Feel free to correct my spelling :)

I'm not aware of anybody using that method.

Since your changes are fairly large, I'm delaying release until a few 
other nice things get added and doing a 1.200 release anyway I think, so 
it's fine.

We'll do a couple of dev releases before the real one, to shake out any 
minor things.

Adam K

Chris Dolan wrote:
> The word "separator" is often misspelled as "seperator" in PPI code.   
> I'd like to change this to the correct spelling, but am concerned  
> about breaking compatibility.  It *looks* to me that this would be a  
> very minor incompatibility.  The only external API method that would  
> be affected is PPI::Normal::Standard::remove_statement_seperator().   
> Is it OK to change the name of that method?
> 
> Below is a list of all places in the code where this spelling  
> correction would happen.
> 
> Chris
> 
> % egrep -rn seperator lib t | grep -v svn
> lib/PPI/Normal/Standard.pm:37:  remove_statement_seperator    => 2,
> lib/PPI/Normal/Standard.pm:90:sub remove_statement_seperator {
> lib/PPI/Token/_QuoteEngine/Full.pm:25:          'q'   => { operator  
> => 'q',   braced => undef, seperator => undef, _sections => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:26:          'qq'  => { operator  
> => 'qq',  braced => undef, seperator => undef, _sections => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:27:          'qx'  => { operator  
> => 'qx',  braced => undef, seperator => undef, _sections => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:28:          'qw'  => { operator  
> => 'qw',  braced => undef, seperator => undef, _sections => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:29:          'qr'  => { operator  
> => 'qr',  braced => undef, seperator => undef, _sections => 1,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:30:          'm'   => { operator  
> => 'm',   braced => undef, seperator => undef, _sections => 1,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:31:          's'   => { operator  
> => 's',   braced => undef, seperator => undef, _sections => 2,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:32:          'tr'  => { operator  
> => 'tr',  braced => undef, seperator => undef, _sections => 2,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:35:          'y'   => { operator  
> => 'y',   braced => undef, seperator => undef, _sections => 2,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:37:          '/'   => { operator  
> => undef, braced => 0,     seperator => '/',   _sections => 1,  
> modifiers => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:40:          '<'   => { operator  
> => undef, braced => 1,     seperator => undef, _sections => 1, },
> lib/PPI/Token/_QuoteEngine/Full.pm:45:          '?'   => { operator  
> => undef, braced => 0,     seperator => '?',   _sections => 1,  
> modifieds => 1 },
> lib/PPI/Token/_QuoteEngine/Full.pm:110:         # operator and the  
> opening seperator.
> lib/PPI/Token/_QuoteEngine/Full.pm:123:         # The character we  
> are now on is the seperator. Capture,
> lib/PPI/Token/_QuoteEngine/Full.pm:134:                 $self-> 
> {seperator} = $sep;
> lib/PPI/Token/_QuoteEngine/Full.pm:163: # Get the content up to the  
> next seperator
> lib/PPI/Token/_QuoteEngine/Full.pm:164: my $string = $self- 
>  >_scan_for_unescaped_character( $t, $self->{seperator} );
> lib/PPI/Token/_QuoteEngine/Full.pm:187: # Get the content up to the  
> end seperator
> lib/PPI/Token/_QuoteEngine/Full.pm:188: $string = $self- 
>  >_scan_for_unescaped_character( $t, $self->{seperator} );
> lib/PPI/Token/_QuoteEngine/Simple.pm:19:        my $seperator = shift  
> or return undef;
> lib/PPI/Token/_QuoteEngine/Simple.pm:21:        # Create a new token  
> containing the seperator
> lib/PPI/Token/_QuoteEngine/Simple.pm:25:        my $self =  
> PPI::Token::new( $class, $seperator ) or return undef;
> lib/PPI/Token/_QuoteEngine/Simple.pm:26:        $self->{seperator} =  
> $seperator;
> lib/PPI/Token/_QuoteEngine/Simple.pm:36:        # Scan for the end  
> seperator
> lib/PPI/Token/_QuoteEngine/Simple.pm:37:        my $string = $self- 
>  >_scan_for_unescaped_character( $t, $self->{seperator} );
> t/02_api.t:414:remove_statement_seperator=method
> t/08_regression.t:90:   seperator => undef,
> t/08_regression.t:121:  seperator => undef,
> 
>