#14 Standardize packed structure definitions

open
Peter C
5
2008-08-11
2008-08-11
No

The structures defined as packed but also including a MD5Hash structure were not really being packed. This could be an issue with portability between systems/compilers.

I think we have always been OK, since none of these structures really need to be packed (I think), but this patch results in the structures really being packed should that be necessary. As a side effect, all MD5Hash structures are also packed, but again, I don't think they included any padding before, they should not be any different declared packed, other than maybe some compiler specific ordering that is no longer done.

Discussion

  • chasm!killer

    chasm!killer - 2008-08-11

    Patch to fix libpar2 structure packing

     
  • chasm!killer

    chasm!killer - 2008-08-11

    Patch to fix par2-cmdline structure packing

     
  • chasm!killer

    chasm!killer - 2008-08-11

    Logged In: YES
    user_id=2175902
    Originator: YES

    File Added: patch-cmdline2

     

Log in to post a comment.