[PanoTools-devel] [ panotools-Bugs-2993085 ] Wrong order of
inclusion of <windows.h> and <jpeglib.h>
From: SourceForge.net <no...@so...> - 2010-04-27 16:39:42
|
Bugs item #2993085, was opened at 2010-04-27 18:39 Message generated for change (Tracker Item Submitted) made by vog You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=613954&aid=2993085&group_id=96188 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: windows build Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Volker Grabsch (vog) Assigned to: Nobody/Anonymous (nobody) Summary: Wrong order of inclusion of <windows.h> and <jpeglib.h> Initial Comment: When cross-compiling libpano13 for Windows, an error regarding duplicate definition of INT32 occurs. This is due to the fact that jpeg.c includes <jpeglib.h> before including <windows.h>, which is not intended to work. The attached patch simply removes one redundant "#include <jpeglib.h>". That way, the '#include "filter.h"' indirectly includes <windows.h>, and the following '#include "jpegicc.h"' indirectly includes <jpeglib.h>, thus having them in their correct order. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=613954&aid=2993085&group_id=96188 |
[PanoTools-devel] [ panotools-Bugs-2993085 ] Wrong order of
inclusion of <windows.h> and <jpeglib.h>
From: SourceForge.net <no...@so...> - 2010-04-27 16:51:43
|
Bugs item #2993085, was opened at 2010-04-27 09:39 Message generated for change (Comment added) made by dmg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=613954&aid=2993085&group_id=96188 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: windows build Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Volker Grabsch (vog) Assigned to: Nobody/Anonymous (nobody) Summary: Wrong order of inclusion of <windows.h> and <jpeglib.h> Initial Comment: When cross-compiling libpano13 for Windows, an error regarding duplicate definition of INT32 occurs. This is due to the fact that jpeg.c includes <jpeglib.h> before including <windows.h>, which is not intended to work. The attached patch simply removes one redundant "#include <jpeglib.h>". That way, the '#include "filter.h"' indirectly includes <windows.h>, and the following '#include "jpegicc.h"' indirectly includes <jpeglib.h>, thus having them in their correct order. ---------------------------------------------------------------------- >Comment By: Daniel M. German (dmg) Date: 2010-04-27 09:51 Message: Committed. Thank you --dmg ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=613954&aid=2993085&group_id=96188 |