From: D M G. <dm...@uv...> - 2011-03-03 08:25:46
|
Jim, to save you the trouble of merging my changes to default, I have merged them into your branch. perhaps the most important change is that we no longer have USHORT, or pt_uint16, rather, we only use uint16_t, which is the standard way to do it. I have tested my changes and they seem to work. Also, there is some windows-centric code that I ported to Linux. You will see an ifdef for it (way to extract local time). can you please first check if the linux code works under windows too (it is standard code, so it _should_ work). If it does, remove the ifdef and the windows code, if not leave it as it with the proper ifdef condition. --dmg -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Jim W. <jwa...@ph...> - 2011-03-03 20:11:59
|
On 2011-03-03 4:25 AM, D M German wrote: > Jim, > > to save you the trouble of merging my changes to default, I have merged > them into your branch. Thank you. > Also, there is some windows-centric code that I ported to Linux. You > will see an ifdef for it (way to extract local time). can you please > first check if the linux code works under windows too (it is standard > code, so it _should_ work). If it does, remove the ifdef and the windows > code, if not leave it as it with the proper ifdef condition. There was a problem with the timezone. We need numeric string ±HHMM, and it was producing a a long string of the time zone instead. I updated it to use a separate functin to get the time zone info needed. Currently we are using fseek and ftell to get and set the file pointer position. These functions use long on windows there is _fseeki64 and _ftelli64 that use 64bit values on Windows. What is available on Linux? -- Jim Watters http://photocreations.ca |
From: dmg <dm...@uv...> - 2011-03-03 20:44:55
|
#define _LARGEFILE64_SOURCE. Then all off_t operations are 64 bit aware. Then use fseeko and ftello, that force parameters and return values to be off_t data types instead of longs. fseeko and ftell are C99 standard. Is there something similar in Windows? What si the default data type for off_t? #ifdef __windows__ #else #define _LARGEFILE64_SOURCE #include <sys/types.h> #include <unistd.h> #endif It is recommended to add the define _LARGEFILE64_SOURCE to the build process. --dmg On Thu, Mar 3, 2011 at 12:10 PM, Jim Watters <jwa...@ph...> wrote: > On 2011-03-03 4:25 AM, D M German wrote: >> Jim, >> >> to save you the trouble of merging my changes to default, I have merged >> them into your branch. > Thank you. > >> Also, there is some windows-centric code that I ported to Linux. You >> will see an ifdef for it (way to extract local time). can you please >> first check if the linux code works under windows too (it is standard >> code, so it _should_ work). If it does, remove the ifdef and the windows >> code, if not leave it as it with the proper ifdef condition. > There was a problem with the timezone. We need numeric string ±HHMM, and it was > producing a a long string of the time zone instead. I updated it to use a > separate functin to get the time zone info needed. > > Currently we are using fseek and ftell to get and set the file pointer position. These functions use long on windows there is _fseeki64 and _ftelli64 that use 64bit values on Windows. What is available on Linux? > > > > -- > Jim Watters > http://photocreations.ca > > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > PanoTools-devel mailing list > Pan...@li... > https://lists.sourceforge.net/lists/listinfo/panotools-devel > > -- --dmg --- Daniel M. German http://turingmachine.org |
From: D M G. <dm...@uv...> - 2011-03-03 20:48:10
|
dmg twisted the bytes to say: dmg> fseeko and ftell are C99 standard. Is there something similar in dmg> Windows? What si the default data type for off_t? Sorry, I meant ftello. In my experience, fseek and ftell switch to 64 by just using the define. But it does not hurt to replace them with fseeko/ftello to make it explicit that we have 64bit aware code. -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |