From: Bruno P. <br...@po...> - 2006-05-26 15:05:12
|
There is an unresolved bug here: http://sourceforge.net/tracker/?func=detail&atid=613954&aid=1487709&group_id=96188 This seems to be caused by InsertFileName being moved around so that it is currently in ptpicker.c. If pano12 is built using ./configure --without-java, this file doesn't get compiled and compilation fails. So it seems the solution is to put the function into javastub.c? or back into PTcommon.c? -- Bruno |
From: Max L. <max...@ve...> - 2006-05-26 20:29:39
|
I think I was the last one to touch it, on May 15. However, this was three days after the bug was submitted (May 12), so it isn't clear to me what the latest status is. On May 15, I removed it from PTCommon.c because it was preventing compilation with MingW on my Win32 system. I'm not sure what the fix should be here... Max > There is an unresolved bug here: > > http://sourceforge.net/tracker/?func=detail&atid=613954&aid=1487709&group_id=96188 > > This seems to be caused by InsertFileName being moved around so that > it is currently in ptpicker.c. If pano12 is built using ./configure > --without-java, this file doesn't get compiled and compilation fails. > > So it seems the solution is to put the function into javastub.c? or > back into PTcommon.c? > > -- > Bruno > > > ------------------------------------------------------- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > _______________________________________________ > PanoTools-devel mailing list > Pan...@li... > https://lists.sourceforge.net/lists/listinfo/panotools-devel |
From: Daniel M. G. <dmg...@uv...> - 2006-05-26 23:52:36
|
Hi Bruno, This bug is history. The function was not exported in some of the .def files. It should now work for everybody. I think we need a new version, don't you think? I suggest we just increase to 2.8.4 and work towards 2.9.0 It will simplify bug reporting. dmg Max Lyons twisted the bytes to say: > I think I was the last one to touch it, on May 15. However, this was three > days after the bug was submitted (May 12), so it isn't clear to me what the > latest status is. > On May 15, I removed it from PTCommon.c because it was preventing compilation > with MingW on my Win32 system. I'm not sure what the fix should be here... > Max >> There is an unresolved bug here: >> >> http://sourceforge.net/tracker/?func=detail&atid=613954&aid=1487709&group_id=96188 >> >> This seems to be caused by InsertFileName being moved around so that >> it is currently in ptpicker.c. If pano12 is built using ./configure >> --without-java, this file doesn't get compiled and compilation fails. >> >> So it seems the solution is to put the function into javastub.c? or >> back into PTcommon.c? >> >> -- >> Bruno >> >> >> ------------------------------------------------------- >> All the advantages of Linux Managed Hosting--Without the Cost and Risk! >> Fully trained technicians. The highest number of Red Hat certifications in >> the hosting industry. Fanatical Support. Click to learn more >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 >> _______________________________________________ >> PanoTools-devel mailing list >> Pan...@li... >> https://lists.sourceforge.net/lists/listinfo/panotools-devel > ------------------------------------------------------- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > _______________________________________________ > PanoTools-devel mailing list > Pan...@li... > https://lists.sourceforge.net/lists/listinfo/panotools-devel -- Daniel M. German "Will I dream? " HAL 9000 http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Bruno P. <br...@po...> - 2006-05-27 11:57:55
|
Daniel M. German wrote: > > This bug is history. The function was not exported in some of the .def > files. It should now work for everybody. I thought the .def files were for windows only? The bug report was on Ubuntu Linux. > I think we need a new version, don't you think? I suggest we just > increase to 2.8.4 and work towards 2.9.0 It will simplify bug > reporting. Good idea. I think we should tag and release fairly often even if some releases are broken. I can do one this weekend unless anyone has an objection. -- Bruno |
From: Daniel M. G. <dmg...@uv...> - 2006-05-27 13:47:31
|
Bruno> Daniel M. German wrote: >> >> This bug is history. The function was not exported in some of the .def >> files. It should now work for everybody. Bruno> I thought the .def files were for windows only? The bug report was Bruno> on Ubuntu Linux. I don't think so (again, I am not an expert in dynamic linking) but I believe libpano12.def is used by Linux too (it is certainly used by gcc under OS X). >> I think we need a new version, don't you think? I suggest we just >> increase to 2.8.4 and work towards 2.9.0 It will simplify bug >> reporting. Bruno> Good idea. I think we should tag and release fairly often even if Bruno> some releases are broken. I can do one this weekend unless anyone Bruno> has an objection. Yes, this is important these days, because we will start getting bug reports. At least we will know what they are talking about it :) Thanks Bruno! daniel Bruno> -- Bruno> Bruno Bruno> ------------------------------------------------------- Bruno> All the advantages of Linux Managed Hosting--Without the Cost and Risk! Bruno> Fully trained technicians. The highest number of Red Hat certifications in Bruno> the hosting industry. Fanatical Support. Click to learn more Bruno> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 Bruno> _______________________________________________ Bruno> PanoTools-devel mailing list Bruno> Pan...@li... Bruno> https://lists.sourceforge.net/lists/listinfo/panotools-devel -- Daniel M. German "Heisenbug is a bug that disappears or alters its behavior when one Jargon Dictionary -> attempts to probe or isolate it." http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Bruno P. <br...@po...> - 2006-05-28 22:29:31
|
On Sat 27-May-2006 at 12:57 +0100, Bruno Postle wrote: > > Good idea. I think we should tag and release fairly often even if > some releases are broken. I can do one this weekend unless anyone > has an objection. I tagged release-2-8-3 as everything seems ok on Linux. Then tried building with mingw and get these errors: PTmender.o(.text+0x24e): In function `main': C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: undefined reference to `ptQuietFlag' PTmender.o(.text+0x3a3):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:351: undefined reference to `CreatePanorama' PTmender.o(.text+0x61e):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:324: undefined reference to `InsertFileName' PTmender.o(.text+0x6aa):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:261: undefined reference to `InsertFileName' Copying pano12.def to libpano12.def still fails: PTmender.o(.text+0x24e): In function `main': C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: undefined reference to `ptQuietFlag' -- Bruno |
From: Daniel M. G. <dmg...@uv...> - 2006-05-28 22:41:45
|
Bruno Postle twisted the bytes to say: PTmender.o(.text+0x24e): In function `main': C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: undefined reference to `ptQuietFlag' PTmender.o(.text+0x3a3):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:351: undefined reference to `CreatePanorama' PTmender.o(.text+0x61e):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:324: undefined reference to `InsertFileName' PTmender.o(.text+0x6aa):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:261: undefined reference to `InsertFileName' Bruno> Copying pano12.def to libpano12.def still fails: PTmender.o(.text+0x24e): In function `main': C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: undefined reference to `ptQuietFlag' Hi Bruno, Would you mind trying the following? Add ptQuietFlag @182 at the bottom of the def files and try to compile again. I could move the variable to PTmender instead (it is currently defined in PTcommon.c) -- Daniel M. German " Despite its apparent simplicity, the pen could claim to be the most significant technology ever developed." The Economist http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Bruno P. <br...@po...> - 2006-05-29 15:25:55
|
On Sun 28-May-2006 at 15:42 -0700, Daniel M. German wrote: > > Add > ptQuietFlag @182 > at the bottom of the def files and try to compile again. I get more similar errors. So to get it to build on windows/mingw with ./configure && make, I have to copy pano12.def to libpano12.def and add all this to the bottom: ptQuietFlag @182 ReplaceExt @183 ColourBrightness @184 TiffSetImageParameters @185 TiffGetImageParameters @186 getCropInformationFromTiff @187 Then it seems ok, PTmender fails your TIFF tests but the files are the right size (except 'deflate' which isn't supported by this libtif). -- Bruno |
From: Max L. <max...@ve...> - 2006-05-29 16:22:38
|
> That's as far as i've investigated. If I comment these lines out, it all builds > OK, but not with these lines included. A quick addendum: I also need to comment out #include <tiffio.h> at the top of PTCommon.h in order to get it to build. |
From: Max L. <max...@ve...> - 2006-05-29 16:13:41
|
I've also been having some compilation problems on my Windows XP / MingW system. At first, I thought it might be because I've been using my own build script, so I've spent the morning downloading and struggling with msys, autoconf, configure, and so on (that is another story, worthy of an even longer e-mail than this one...but will have to wait). Anyway, I've managed to get things building using this approach, but am running into the same errors as with my own "home-made" build script. The problem appears to be that INT32 is defined in two places: /mingw/include/basetsd.h:52: typedef int INT32, *PINT32; /libjpeg/jpeg-6b/jmorecfg.h: typedef long INT32; Here's what the compiler (gcc 3.4.2) spits out: In file included from c:/mingw/include/winnt.h:164, from c:/mingw/include/windef.h:246, from c:/mingw/include/windows.h:48, from ../../LibTiff/tiff-v3.6.1/libtiff/tiffio.h:89, from PTcommon.h:34, from panorama.h:312, from filter.h:32, from jpeg.c:4: c:/mingw/include/basetsd.h:52: error: conflicting types for 'INT32' ../../libjpeg/jpeg-6b/jmorecfg.h:161: error: previous declaration of 'INT32' was here This is a new error, and I've traced it back to recent addition of these declarations into ptcommon.h (I think as part of the PTUncrop changes?): void getCropInformationFromTiff(TIFF *tif, CropInfo *c); int TiffGetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); int TiffSetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); That's as far as i've investigated. If I comment these lines out, it all builds OK, but not with these lines included. (I suspect that I won't be able to build ptuncrop until this is resolved, as well...haven't tried that yet.) Max > > Bruno Postle twisted the bytes to say: > > > PTmender.o(.text+0x24e): In function `main': > C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: > undefined reference to `ptQuietFlag' > PTmender.o(.text+0x3a3):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:351: > undefined reference to `CreatePanorama' > PTmender.o(.text+0x61e):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:324: > undefined reference to `InsertFileName' > PTmender.o(.text+0x6aa):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:261: > undefined reference to `InsertFileName' > > Bruno> Copying pano12.def to libpano12.def still fails: > > PTmender.o(.text+0x24e): In function `main': > C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: > undefined reference to `ptQuietFlag' > > Hi Bruno, > > Would you mind trying the following? > > Add > > ptQuietFlag @182 > > at the bottom of the def files and try to compile again. > > I could move the variable to PTmender instead (it is currently defined > in PTcommon.c) > > > -- > Daniel M. German " Despite its apparent simplicity, the pen could claim to be the most significant technology ever developed." > The Economist > http://turingmachine.org/ > http://silvernegative.com/ > dmg (at) uvic (dot) ca > replace (at) with @ and (dot) with . > > > > > ------------------------------------------------------- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > _______________________________________________ > PanoTools-devel mailing list > Pan...@li... > https://lists.sourceforge.net/lists/listinfo/panotools-devel |
From: Bruno P. <br...@po...> - 2006-05-29 16:43:47
|
On Mon 29-May-2006 at 12:13 -0400, Max Lyons wrote: > c:/mingw/include/basetsd.h:52: error: conflicting types for 'INT32' > ../../libjpeg/jpeg-6b/jmorecfg.h:161: error: previous declaration of 'INT32' > was here > > This is a new error, and I've traced it back to recent addition of these > declarations into ptcommon.h (I think as part of the PTUncrop changes?): Oops forgot to say, I commented this line out from basetsd.h to get it to compile. -- Bruno |
From: Daniel M. G. <dmg...@uv...> - 2006-05-29 16:55:18
|
Max> I've also been having some compilation problems on my Windows XP / MingW Max> system. These are strange errors, and they probably have to do with the fact that every library tries to define their own integer types instead of using the library ones. In fact, panotools is guilty of exactly the same problem (and a potential bug, I might add, see panotypes.h, where pt_uint32 is hardcoded as an unsigned int. I am very tempted to 1. fix them by changing them to uint16_t, or 2. add some asserts that guarantee it will fail in systems with ints of different size). Ok, back to the problem we have. One of the major changes I introduced was, as Max pointed out, to add some functions to PTcommon.h, and then export them. Here is what I suggest (I'd do it myself, but I don't have a windows setup to test them, would anybody recommend a place to learn what MingW is? i recently got a windows laptop but I have not set up for development yet). * REmove the 3 functions that are creating the problem from PTcommon.h Max> void getCropInformationFromTiff(TIFF *tif, CropInfo *c); Max> int TiffGetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); Max> int TiffSetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); * Remove the tiffio.h include from PTcommon.h * Add a file called tiff.h, add the 3 declarations here. * Add #include "tiff.h" to PTuncrop.c and PTcommon.c Hopefully this will fix it. I think the problem is that tiffio.h should not be compiled along every file. This is really just a workaround. THe problem is not libpano, it is in jmorecfg.h. Max> At first, I thought it might be because I've been using my own build script, so Max> I've spent the morning downloading and struggling with msys, autoconf, Max> configure, and so on (that is another story, worthy of an even longer e-mail Max> than this one...but will have to wait). Anyway, I've managed to get things Max> building using this approach, but am running into the same errors as with my Max> own "home-made" build script. Max> The problem appears to be that INT32 is defined in two places: Max> /mingw/include/basetsd.h:52: typedef int INT32, *PINT32; Max> /libjpeg/jpeg-6b/jmorecfg.h: typedef long INT32; Max> Here's what the compiler (gcc 3.4.2) spits out: Max> In file included from c:/mingw/include/winnt.h:164, from c:/mingw/include/windef.h:246, from c:/mingw/include/windows.h:48, from ../../LibTiff/tiff-v3.6.1/libtiff/tiffio.h:89, from PTcommon.h:34, from panorama.h:312, from filter.h:32, from jpeg.c:4: Max> c:/mingw/include/basetsd.h:52: error: conflicting types for 'INT32' Max> ../../libjpeg/jpeg-6b/jmorecfg.h:161: error: previous declaration of 'INT32' Max> was here Max> This is a new error, and I've traced it back to recent addition of these Max> declarations into ptcommon.h (I think as part of the PTUncrop changes?): Max> void getCropInformationFromTiff(TIFF *tif, CropInfo *c); Max> int TiffGetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); Max> int TiffSetImageParameters(TIFF *tiffFile, pt_tiff_parms *tiffData); Max> That's as far as i've investigated. If I comment these lines out, it all builds Max> OK, but not with these lines included. (I suspect that I won't be able to Max> build ptuncrop until this is resolved, as well...haven't tried that yet.) Max> Max >> >> Bruno Postle twisted the bytes to say: >> >> >> PTmender.o(.text+0x24e): In function `main': >> C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: >> undefined reference to `ptQuietFlag' >> PTmender.o(.text+0x3a3):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:351: >> undefined reference to `CreatePanorama' >> PTmender.o(.text+0x61e):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:324: >> undefined reference to `InsertFileName' >> PTmender.o(.text+0x6aa):C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:261: >> undefined reference to `InsertFileName' >> Bruno> Copying pano12.def to libpano12.def still fails: >> >> PTmender.o(.text+0x24e): In function `main': >> C:/msys/1.0/home/Bruno.Postle/libpano12-2.8.3/tools/PTmender.c:115: >> undefined reference to `ptQuietFlag' >> >> Hi Bruno, >> >> Would you mind trying the following? >> >> Add >> >> ptQuietFlag @182 >> >> at the bottom of the def files and try to compile again. >> >> I could move the variable to PTmender instead (it is currently defined >> in PTcommon.c) >> >> >> -- >> Daniel M. German " Despite its apparent simplicity, the pen could claim to be the most significant technology ever developed." >> The Economist >> http://turingmachine.org/ >> http://silvernegative.com/ >> dmg (at) uvic (dot) ca >> replace (at) with @ and (dot) with . >> >> >> >> >> ------------------------------------------------------- >> All the advantages of Linux Managed Hosting--Without the Cost and Risk! >> Fully trained technicians. The highest number of Red Hat certifications in >> the hosting industry. Fanatical Support. Click to learn more >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 >> _______________________________________________ >> PanoTools-devel mailing list >> Pan...@li... >> https://lists.sourceforge.net/lists/listinfo/panotools-devel -- Daniel M. German "For indeed who is there alive that will not be swayed by his bias and partiality to Jonathan Swift -> the place of his birth?" http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Bruno P. <br...@po...> - 2006-05-29 17:05:59
|
On Mon 29-May-2006 at 09:56 -0700, Daniel M. German wrote: > > Here is what I suggest (I'd do it myself, but I don't have a windows > setup to test them, would anybody recommend a place to learn what > MingW is? i recently got a windows laptop but I have not set up for > development yet). It's a POSIX environment for Windows, so you get a UNIX shell and all the usual GNU build tools, except everything that you compile is a win32 binary that works on any Windows system: http://www.panotools.info/mediawiki/index.php?title=Build_pano12_from_sourcecode -- Bruno |
From: Max L. <max...@ve...> - 2006-05-29 17:17:20
|
> Here is what I suggest... Daniel: Your suggestion worked nicely. I've made the changes, and added a new file called "pttiff.h". I didn't want it to get confused with the tiff.h file that is part of libtiff so I named it differently. I also updated pano12.def and libpano12.def with the latest, up-to-date, exports (I hope). I've confirmed that it builds correctly for me, and checked all this back into the repository. I'm going to go back to using my home-brewed build script as the msys/automake/autoconf/configure stuff gave me real headaches, and wasn't going to deal with my system nicely until I'd rearranged all my libraries (which I use for a number of other projects that I don't want to mess with) in a way that made it happy! I don't know if the addition of this new file will have any implications for the various files that are part of automake/autoconf/etc., but perhaps someone who has more familiarity with this can answer that? Max |
From: Daniel M. G. <dmg...@uv...> - 2006-05-29 17:50:50
|
Thanks Max, One thing, you forgot to add the new file to the repository (pttiff.h). Max> Your suggestion worked nicely. I've made the changes, and added a new file Max> called "pttiff.h". I didn't want it to get confused with the tiff.h file that Max> is part of libtiff so I named it differently. Max> I also updated pano12.def and libpano12.def with the latest, up-to-date, Max> exports (I hope). Max> I've confirmed that it builds correctly for me, and checked all this back into Max> the repository. Max> I'm going to go back to using my home-brewed build script as the Max> msys/automake/autoconf/configure stuff gave me real headaches, and wasn't going Max> to deal with my system nicely until I'd rearranged all my libraries (which I Max> use for a number of other projects that I don't want to mess with) in a way Max> that made it happy! Max> I don't know if the addition of this new file will have any implications for Max> the various files that are part of automake/autoconf/etc., but perhaps someone Max> who has more familiarity with this can answer that? Max> Max -- Daniel M. German "The energy of the world is constant. Rudolf Clausius -> Its entropy tends to a maximum." http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Max L. <max...@ve...> - 2006-05-29 18:23:59
|
Sorry about that...I've checked it in now. Max > One thing, you forgot to add the new file to the repository > (pttiff.h). > |
From: Max L. <max...@ve...> - 2006-05-30 02:56:26
|
I've made some more changes to PTMender and PTUncrop I moved the uncropping logic from PTUncop into PTCommon so that it could be reused by PTMender. I modified PTMender so that it now uses cropped TIFF as the intermediate format for all processing, regardless of output format. (Previously, PTMender used full-size TIFF as the intermediate format when generating full size TIFF_m or TIFF_mask output). Uncropped TIFFs can be generated, if needed, from cropped TIFFs by calling the new "uncropTiff" function in PTCommon.c. Both PTMender.exe and PTUncrop.exe now use this function. A complete list of changes is below. Max ========================================== 2006-05-29 Max Lyons <max...@ta...> * adjust.c: CheckParams: Allowing optimizer to work with new projections * Moving uncrop logic from ptuncrop.c to ptcommon.c. Creating uncropTiff function * Adding uncropTiff function declaration to pttiff.h * Making cropped TIFF the intermediate format for all processing, regardless of output format. Uncropped TIFFs can be generated, if needed, from intermediate cropped TIFFs by calling new uncropTiff function. |
From: Bruno P. <br...@po...> - 2006-05-30 20:06:53
|
On Mon 29-May-2006 at 13:17 -0400, Max Lyons wrote: > > Your suggestion worked nicely. I've made the changes, and added a > new file called "pttiff.h". > I don't know if the addition of this new file will have any > implications for the various files that are part of > automake/autoconf/etc., but perhaps someone who has more > familiarity with this can answer that? I can't say I'm familiar, but all it needed was to add the filename to Makefile.am (done). -- Bruno |