Menu

#5 Choose different decoder for m4a files with ALAC and AAC audio codec

Next_Release_
closed
None
5
2018-04-22
2018-03-10
No

As M4A audio files can have either ALAC or AAC audio codec streams, it would be extremely useful if pacpl could choose a decoder for M4A files only after analyzing the audio streams they contain: if the codec is ALAC, the default decoder can be ffmpeg or alac-decoder, but if it's AAC then the decoder would could be faad. Currently, pacpl decides the decoder based only on the extension (M4A), choosing faad as the default, so it fails to automatically decode M4A files with ALAC audio codec — of course, it can decode ALAC-based M4A files with command-line option --decoder ffmpeg, but it would be useful if pacpl could decide that automatically, without manual intervention.

Related

Feature Requests: #5

Discussion

  • Paulo Marcel Coelho Aragão

    To accomodate this feature request, I modified pacpl so that it chooses the decoder/encoder based on the codec of the audio file. For m4a files, it gets the codec by calling Audio::Scan->scan_info(<file>)->{info}->{tracks}[0]->{encoding}, and for the other audio files, it treats the extension as the codec. To that end, I removed the m4a entry from %run, and added entries for mp4a and alac, which are the codecs that Audio::Scan reports for m4a files with AAC codec and m4a with ALAC codec, respectively.

    So, effectively, only the handling of m4a files has been changed.

    I've attached a patch.

     
    • Philip Lyons

      Philip Lyons - 2018-03-26

      How would you like a job?

      On Mon, Mar 26, 2018, 3:12 PM "Paulo Marcel Coelho Aragão" marcelpaulo@users.sourceforge.net wrote:

      To accomodate this feature request, I modified pacpl so that it chooses
      the decoder/encoder based on the codec of the audio file. For m4a
      files, it gets the codec by calling
      Audio::Scan->scan_info(<file>)->{info}->{tracks}[0]->{encoding}, and for
      the other audio files, it treats the extension as the codec. To that end, I
      removed the m4a entry from %run, and added entries for mp4a and alac,
      which are the codecs that Audio::Scan reports for m4a files with AAC
      codec and m4a with ALAC codec, respectively.

      So, effectively, only the handling of m4a files has been changed.

      I've attached a patch.

      Attachments:


      Status: open
      Group: Next_Release_
      Created: Sat Mar 10, 2018 01:05 AM UTC by Paulo Marcel Coelho Aragão
      Last Updated: Sat Mar 10, 2018 01:05 AM UTC
      Owner: nobody

      As M4A audio files can have either ALAC or AAC audio codec streams,
      it would be extremely useful if pacpl could choose a decoder for M4A files
      only after analyzing the audio streams they contain: if the codec is ALAC,
      the default decoder can be ffmpeg or alac-decoder, but if it's AAC
      then the decoder would could be faad. Currently, pacpl decides the
      decoder based only on the extension (M4A), choosing faad as the default, so
      it fails to automatically decode M4A files with ALAC audio codec — of
      course, it can decode ALAC-based M4A files with command-line option --decoder
      ffmpeg, but it would be useful if pacpl could decide that automatically,
      without manual intervention.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/pacpl/feature-requests/5/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Feature Requests: #5

  • Philip Lyons

    Philip Lyons - 2018-04-22
    • status: open --> closed
    • assigned_to: Philip Lyons
     
  • Philip Lyons

    Philip Lyons - 2018-04-22

    Patch implemented. Lets try to get on the same page conserning the app version number =)

     

Log in to post a comment.