Menu

#16 Option --overwrite is misleading since by default pacpl overwrites

PACPL
closed
None
5
2018-02-21
2018-02-06
No

pacpl by default overwrites the output files, so command-line option --overwrite is misleading since it implies that, without the option, output files are not overwritten.

Discussion

  • Philip Lyons

    Philip Lyons - 2018-02-07
    • status: open --> pending
    • assigned_to: Philip Lyons
     
  • Paulo Marcel Coelho Aragão

    The destination was always being overwritten because the test to check if the destination already existed was using only the filename and not the full pathname. So it was needed to prepend the directory name to the filename. I've attached a patch.

     
  • Philip Lyons

    Philip Lyons - 2018-02-20
    • status: pending --> closed-works-for-me
     
  • Philip Lyons

    Philip Lyons - 2018-02-20

    rel2abs covers this, therefore no modification is necessary.

     
  • Paulo Marcel Coelho Aragão

    The perl code handling the --overwrite is wrong and needs to be changed according to the patch I sent. It is impossible that it may work for you or anybody else. You can't close an issue like that without even bothering to look at the patch. I took the time to debug your code and offer a patch, so that your program works better, or rather, so that it works as expected. If you don't incorporate the patch, your program will go on faulty.

     
  • Philip Lyons

    Philip Lyons - 2018-02-21
    • status: closed-works-for-me --> closed
     
  • Philip Lyons

    Philip Lyons - 2018-02-21

    I've further reviewed the patches submitted them to git.

     

Log in to post a comment.