Re: [Packetnet-devel] Patches

[Chris M. <chm...@gm...>]

If you want to take a look at the checksum issue that would be cool. I
didn't really have much interest in debugging it at this point so have
at it :-)

Chris



On Wed, Mar 3, 2010 at 8:19 PM, Chris Morgan <chm...@gm...> wrote:
> Alright, all three of these are applied. Thanks man.
>
> I modified the one nunit patch to remove the "using  System.XML;"
> because that entry is only necessary if code needed it, it isn't
> related to the missing reference to System.XML.
>
> Chris
>
>
> On Wed, Mar 3, 2010 at 9:07 AM, Chris Morgan <chm...@gm...> wrote:
>> Hi Evan.
>>
>> I can view these patches now.
>>
>> Sorry about not making the changes last night, I'll apply them as soon
>> as I get home today because they are all perfectly reasonable things
>> to fix.
>>
>> Chris
>>
>>
>>
>> On Mar 3, 2010, at 6:10 AM, Evan Plaice <eva...@gm...> wrote:
>>
>>> Resubmitting the NUnit fix for windows patch as well as the
>>> Array.Copy vs Buffer.BlockCopy patch due to Windows end line conficts.
>>>
>>> Also added a patch to ignore unnecessary files generated by Visual
>>> Studio.
>>>
>>> Patch 0001:
>>> Modified .gitignore to exclude
>>> - /obj/ folders and sub-folders which contain object files,
>>> binaries, and dll files generated from build/debug
>>> - .suo files which contain user-specific settings specific to Visual
>>> Studio
>>>
>>> Patch 0002:
>>> Fixed NUnit to work with Visual Studio
>>> - Everything compiled fine before changing the methods to public but
>>> all of the tests would crash using NUnit 2.5.3.
>>>     This is the error given on all of the tests:
>>>     Invalid signature for SetUp or TearDown method: RunBeforeAnyTests
>>>
>>> - log4net was needed System.Xml, so I added a using statement and a
>>> reference to Test.csproj
>>>     Without this Test would not compile
>>>
>>> Patch 0003:
>>> ByteCopyPerformance test added:
>>> - This test compares Buffer.BlockCopy to Array.Copy
>>>
>>> Evan Plaice
>>> <0001-.gitignore-entries-added-for-Visual-Studio.patch>
>>> <0002-NUnit-Testing-fixed-in-Windows.patch>
>>> <0003-ByteCopyPerformance-test-added.patch>
>>> ---
>>> ---
>>> ---
>>> ---------------------------------------------------------------------
>>> Download Intel&#174; Parallel Studio Eval
>>> Try the new software tools for yourself. Speed compiling, find bugs
>>> proactively, and fine-tune applications for parallel performance.
>>> See why Intel Parallel Studio got high marks during beta.
>>> http://p.sf.net/sfu/intel-sw-dev
>>> _______________________________________________
>>> Packetnet-devel mailing list
>>> Pac...@li...
>>> https://lists.sourceforge.net/lists/listinfo/packetnet-devel
>>
>