Menu

#13 Smaller OTR button

open
nobody
pidgin-otr (4)
5
2007-05-12
2007-05-12
Tasci Synx
No

This request is in response to here:http://sourceforge.net/tracker/index.php?func=detail&aid=1640521&group_id=128860&atid=713091

I'm not allowed to attach files to the above feature request, so I had to make my own to include the patches.

"Please remove the ugly big OTR Button in GAIM and replace it by a smaller
one."

Gods yes! Lesse... okay I don't have CVS write access, but I'll try to get this patch here somehow.

First, I removed the icons from being inline manually typed xpm files. x_x A better way to do that is to use gdk-pixbuf's support for inline pixbufs. Than way someone artistic can make the icons for the button look pretty. gaim-encryption's screenshots showed giant 128 pixel icons that looked very annoying, so I don't know where this "small lock symbol" came from. Anyway, so someone can make "better" images than what is currently (I think) a ripoff of some AIM icons. The 4 icons that are used to display status are:
icons/finished.xpm
icons/unverified.xpm
icons/private.xpm
icons/not_private.xpm

I also made an icons/Makefile.am that uses gdk-pixbuf-csource to convert the images into a pixbuf buffer, then sets those pixbufs to be shipped in EXTRA_DIST. Note for future artists that gdk-pixbuf-csource can take png and jpeg files, not just xpm.

Now, I don't have CVS write access. That means I can't produce a patch that adds files. So I'll attach the 'icons' directory to this feature request. The files in the 'icons' directory are the only files I needed to add. Everything else should be in the cvs diff patch, which I also will attach to this feature request.

Basically the patch makes a global boolean preference /OTR/largeButton. If it is true, then the normal OTR button is displayed, with the two labels and the icon embedded in it. If it is false, then only the icon is embedded in the button, and the two labels are ignored. And again, the icons are now #included from the icons/ directory, and loaded using gdk_pixbuf_load_from_inline(). It's more efficient and flexible than xpms.

You might note that even the "small" button is still pretty tall. Unfortunately I can't see anywhere to stick the OTR button where it would just be a "small lock symbol" in the "top right". The OTR button will always be the same height as the place where you type in your message. You'd have to substantially modify the conversation window, to get anything in the upper right. Perhaps taking the main message dialog and maybe putting it in a hbox/vbox tee, which leaves a space in the upper right corner. Or possibly we could embed the OTR button inside the tab itself? Bah, everyone should design GUIs with grids not bboxes. :p

Discussion

  • Tasci Synx

    Tasci Synx - 2007-05-12

    The status icons, de-coupled from the gtk-dialog file

     
  • Tasci Synx

    Tasci Synx - 2007-05-12

    Logged In: YES
    user_id=691674
    Originator: YES

    File Added: gaim-otr-smallbutton.patch

     
  • Tasci Synx

    Tasci Synx - 2007-05-12

    Small Button patch (this patch DELETES the inline icons, replace them with icons.tar.bz2)

     
  • Tasci Synx

    Tasci Synx - 2007-05-12

    Logged In: YES
    user_id=691674
    Originator: YES

    File Added: gaim-otr-smallbutton.patch

     
  • Nobody/Anonymous

    Logged In: NO

    anyone considering to address this? it really UGLY!

     

Log in to post a comment.