[otcl-tclcl-developers] Otcl changes needed for Tcl 8.6b1

[Lloyd W. <L....@su...>]

Not sure that this list overlaps completely with ns-developers, so forwarding below patch and requested fixes to webpages fyi.

Begin forwarded message:

> From: Lloyd Wood <L....@su...>
> Date: 31 December 2009 01:22:38 GMT
> To: Tom Henderson <to...@to...>, Wesley Eddy <we...@mt...>
> Cc: Lloyd Wood <L....@su...>, ns-developers <ns-...@IS...>
> Subject: Re: [Ns-developers] ns-2 release plans
> 
> On 31 Dec 2009, at 00:37, Tom Henderson wrote:
> 
>> Since the last ns-2 release, I applied a few patches (most recently from Amir Habibi and Maxime de Roucy) to deal with gcc evolution, valgrind warnings, and the migration to Tcl/Tk version 8.5 on many distributions,
> 
> Tried Tcl/Tk 8.6? (the beta 1 ships with Mandriva; Wes Eddy's been playing with it, and pointed its needs out to me.)
> 
> From a wander through various web cvs, I'd expect that otcl's direct accessing of interp->result ("fish result out of interp" etc. - see e.g. otcl.c's use of Tcl_Interp* in->result) and in->errorLine is most likely to be problematic for Tcl 8.6.
> 
> http://savi.cvs.sourceforge.net/viewvc/savi/savi-dev/src/include/tcl_utils.h?r1=1.13&r2=1.14
> got SaVi 1.4.3 working under Tcl 8.6
> 
> 		 /* necessary to tell Tcl 8.6 to be backwards-compatible
> 	 	  * and support interp->result
> 	 	  * Tcl_GetStringResult() / Tcl_SetResult() don't work in 7.x.
> 	 	  * http://www.tcl.tk/man/tcl8.6/TclLib/Interp.htm
> 	 	  */
> 	 	 #ifndef USE_INTERP_RESULT
> 	 	 #define USE_INTERP_RESULT
> 	 	 #endif
> 
> and I expect you'll also need:
> 
> 		 #ifndef USE_INTERP_ERRORLINE
> 	 	 #define USE_INTERP_ERRORLINE
> 	 	 #endif
> 
> before the tcl.h include in otcl.h to get the existing otcl code working under Tcl/Tk 8.6. Untested patch doing this is below at end.
> 
> Other alternatives to these defines are:
> - (easy) putting -DUSE_INTERP_RESULT -DUSE_INTERP_ERRORLINE in the otcl Makefile; not obvious or self-documenting,
> - (harder) rewriting code to use the methods, at the expense of earlier Tcl/Tk.
> 
> Oh,
> http://otcl-tclcl.sourceforge.net/tclcl/
> http://otcl-tclcl.sourceforge.net/otcl/
> the 'recent CHANGES' links need an update, now sourceforge has moved its cvsweb. Links should be to
> http://otcl-tclcl.cvs.sourceforge.net/viewvc/otcl-tclcl/otcl/CHANGES.html
> http://otcl-tclcl.cvs.sourceforge.net/viewvc/otcl-tclcl/tclcl/CHANGES.html
> 
> L.
> 
> satellite constellation visualization: http://savi.sf.net/
> 
> <http://info.ee.surrey.ac.uk/Personal/L.Wood/><L....@su...>
> 
> $ less patch.diff
> *** otcl.h.orig 2009-12-31 01:12:13.000000000 +0000
> --- otcl.h      2009-12-31 01:19:34.000000000 +0000
> ***************
> *** 19,24 ****
> --- 19,33 ----
>  #ifndef _otcl_h_
>  #define _otcl_h_
> 
> + /* make Tcl 8.6 backwards-compatible http://www.tcl.tk/man/tcl8.6/TclLib/Interp.htm */
> + #ifndef USE_INTERP_ERRORLINE
> + #define USE_INTERP_ERRORLINE
> + #endif
> + 
> + #ifndef USE_INTERP_RESULT
> + #define USE_INTERP_RESULT
> + #endif
> + 
>  #include <tcl.h>
> 
>  /* compatible char definition for versions < 8.4 */
> 
> 
> 
> 
> 
> 
> 
> 

DTN work: http://info.ee.surrey.ac.uk/Personal/L.Wood/dtn/

<http://info.ee.surrey.ac.uk/Personal/L.Wood/><L....@su...>