#3186 Billing from any place other than appointment screen sets provider to 1

[Hagir]

Problem: When any doctor on the system is billing, the invoice populate with default to provider no 1. This happens from 3 places:
(1)- Master>create invoice.
(2)- Search>E>sign Save and Bill.
(3)- Master> Echart> sign Save and Bill.

Steps to reproduce:
1- Sign in with provider 99998
2- Create a demographic and assign it to you.
3- Ensure there is a provider with provider_no 1 in the system populated with a billing number (Admin>add provider> No.1 and fill billing number fields).
4- Based on senario (1) above, search>master>create invoice. Notice that the billing physician is defaulted to the other physician although patient is assigned to provider 999998.
5- Try to bill on senario (2) and (3) and result is the same.

Replicated in 12.1.1 #357 and feb2014Alpha

[SBek]

The bug has been replicated as described in R12.1.1 and feb2014alpha

[Hagir]

Victor, I am looking into solving this ticket. The problem is with the providerview parameter that is passed in the URL to the billing module:

On the "Create Invoice" and "Hospital billing" master links, the providerview parameter is hard coded to 1 in the URL in demographiceditdemographic.jsp. This is simple to fix to have it pick the demorgaphic.getProvider() instead.

As for the eChart billing, providerview is passed with null in the URL from demographiceditdemographic.jsp (var called encURL) and for some reason, the ChartNotes.jsp checks for that and converts providerview to 1 if it's null. Do you know why it needs to do that? It's def looks problematic:

String provView = request.getParameter("providerview");
if (provView == null || provView.equals("") || provView.equals("null"))
{
provView = "1";
}

I am not sure if it's better to fix it by adding the correct providerview to the URL link from demographiceditdemographic.jsp or change the way ChartNotes.jsp validates the providerview parameter.

[Victor Van Herk]

Hello Hagir.
I would suggest passing in the providerview parameter correct from all points, that way it is consistent.

Cheers,
Vic

[Hagir]

Thanks Vic! Here are the commits:
R12.1:https://source.oscartools.org:8080/#/c/10173/
feb2014-alpha: https://source.oscartools.org:8080/#/c/10174/
master: https://source.oscartools.org:8080/#/c/10175/

The click on "create invoice" or "hospital billing" from the master assumes you are billing the MRP. Billing from the save-sign and exit on the chart assumes you are billing for yourself.

[Marc Dumontier]

merged

[SBek]

Re-tested R12.1 (build# 396), Trunk (build# 2067) , feb2014-alpha (build# 37) -> Issue has been resolved.