#2569 New consults defaulting appointment date to Jan 1

[Trimara Corporation]

Problem Summary:
When you create a consult it defaults to the current Jan 1 of the current year and 1 AM. This is misleading and makes people think there is an appointment booked for Jan 1, 2013 - it should default to blank until the user sets something. Screenshot attached.

Expected Result:
New consults should have a blank appointment date.

Actual Result:
The consult defaults to Jan 1 of the current year and 1 AM.

Steps to Reproduce:
(1) Create a new consult - the date will be 2013-01-01 at 1:00 AM

Reproduced In:
12_1 Deb 146 (fresh install) + Ubuntu 12 LTS (fresh install)

[Trimara Corporation]

[Victor Van Herk]

Kris.
In looking at this, the date is being defaulted as an appt date is required to save consult.

If we default to blank, and user saves, it will throw an error.

I think this may need a step back, come up with requirements as to what is needed, and create feature request for this, outlining any validations, error handling, messages, etc.

[Trimara Corporation]

Hi Victor. Sure, is there anything we can do to help define the requirements? It's really confusing to have a date selected by default - it makes it look like the user entered an appointment date when they didn't.

[Hagir]

Hi Victor,

The blank appointment has been the default behavior of Oscar since Oscar 12 and before. It had only changed recently (not sure at which point). So should it really be a feature request that will have to wait for in the next release? It's more of a lost feature, and it is important too.

[Trimara Corporation]

Hi Guys. IMHO, I wouldn't say this is feature request. The fact that it has been around for a long time isn't a valid criterion for determining if something is a bug vs. a feature - you need to determine whether it was intended behaviour. In this case, I would say that it's not intended that we would indicate that someone has an appointment booked with a specialist when they don't.

[Victor Van Herk]

Not a problem to keep it a bug. My main concerns is once I fix it, other things come into play (ie: cant save consult with invalid appt date).

So, I will need some requirements on how it should work with regards to error handling, messages, validations, etc.

When it used to default blank, what would happen when a user saved consult with invalid date?

[Trimara Corporation]

I would say that the error handling should be adjusted to allow blank dates. In terms of validation of the date, I tested the current functionality in Deb 146 and if you input an invalid date (e.g. 31-Jun-2013), it fails silently with no warning and sets the date to 01-Jul-2013. I think it would be better if an error message popped up indicating that the date was invalid.

[Trimara Corporation]

How about the following for requirements:

• Default to blank
• Allow the user to save/print the consult with a blank date if they want.
• If the user does select a date, validate to ensure that the date is actually a valid date - i.e. don't allow someone to enter Feb 31st or any other non-valid date.

[Victor Van Herk]

Hello Kris.

Do you have any input to my last comment here, such as requirements for how it should work.

[Trimara Corporation]

Hi Victor. In my opinion, the date should default to blank and there should be validation to ensure that the date is valid. If the date is invalid, the following message should appear: "Invalid appointment date. Please enter a valid date."

Does that give you what you need?

[Victor Van Herk]

Hi Kris.
Sounds good. Will implement this way.

[Marc Dumontier]

I agree

On Sat, Aug 31, 2013 at 8:44 PM, Trimara Corporation trimaracorp@users.sf.net wrote:

Hi Victor. In my opinion, the date should default to blank and there
should be validation to ensure that the date is valid. If the date is
invalid, the following message should appear: "Invalid appointment date.
Please enter a valid date."

Does that give you what you need?

• [bugs:#2569] http://sourceforge.net/p/oscarmcmaster/bugs/2569/ New
  consults defaulting appointment date to Jan 1*

Status: pending
Created: Fri May 31, 2013 12:48 AM UTC by Trimara Corporation
Last Updated: Fri Aug 30, 2013 06:48 PM UTC
Owner: Victor Van Herk

Problem Summary:
When you create a consult it defaults to the current Jan 1 of the current
year and 1 AM. This is misleading and makes people think there is an
appointment booked for Jan 1, 2013 - it should default to blank until the
user sets something. Screenshot attached.

Expected Result:
New consults should have a blank appointment date.

Actual Result:
The consult defaults to Jan 1 of the current year and 1 AM.

Steps to Reproduce:
(1) Create a new consult - the date will be 2013-01-01 at 1:00 AM

Reproduced In:
12_1 Deb 146 (fresh install) + Ubuntu 12 LTS (fresh install)

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/oscarmcmaster/bugs/2569/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

--
Marc Dumontier
519-584-5601
http://oscardevel.com/wordpress/
http://www.oscarmcmaster.org

[Victor Van Herk]

12_1 commit:
https://source.oscartools.org:8080/#/c/8868/

[Victor Van Herk]

trunk commit:
https://source.oscartools.org:8080/#/c/8870/