Menu

#2 fix up DESTINATION in cmake files

1.0
closed
nobody
None
2015-05-12
2015-05-12
No

You have absolute install paths in your CMakeLists.txt files, and, even worse, some files get installed under /usr/local, others under /usr.

The attached patch fixes this and makes it possible for package maintainers to employ your 'make install' target in conjunction with 'cmake -DCMAKE_INSTALL_PREFIX:PATH=...' to install under custom installation prefixes.

1 Attachments

Related

Tickets: #2

Discussion

  • ssj71

    ssj71 - 2015-05-12

    Thank you very much for the patch. I admit I'm pretty clueless about packaging. Patch is now in the master branch of git. I will update the files section when I can.

     
    • Albert Graef

      Albert Graef - 2015-05-12

      Thanks, that was quick. :)

      In return, here's a package for Arch that builds straight from the git
      sources: https://aur.archlinux.org/packages/osc2midi-git/. There's also a
      package for the released version which someone else uploaded last month,
      you can find that here: https://aur.archlinux.org/packages/osc2midi/. (The
      latter still needs to be updated for the 1.0.03 version, as you can see I
      flagged it out-of-date already.)

      Gotta love Arch Linux, it makes it so easy to create packages and always
      have the latest software. :)

      Compiling on Mac OS X also works without a hitch. I'll create a MacPorts
      package as soon as 1.0.03 hits the mirrors and I find some spare time...

      Albert

      On Tue, May 12, 2015 at 8:27 PM, ssj71 ssj71@users.sf.net wrote:

      Thank you very much for the patch. I admit I'm pretty clueless about
      packaging. Patch is now in the master branch of git. I will update the
      files section when I can.


      Status: open
      Milestone: 1.0
      Created: Tue May 12, 2015 06:04 PM UTC by Albert Graef
      Last Updated: Tue May 12, 2015 06:04 PM UTC
      Owner: nobody

      You have absolute install paths in your CMakeLists.txt files, and, even
      worse, some files get installed under /usr/local, others under /usr.

      The attached patch fixes this and makes it possible for package
      maintainers to employ your 'make install' target in conjunction with 'cmake
      -DCMAKE_INSTALL_PREFIX:PATH=...' to install under custom installation
      prefixes.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/osc2midi/tickets/2/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

      --
      Dr. Albert Gr"af
      Computer Music Research Group, JGU Mainz, Germany
      Email: aggraef@gmail.com
      WWW: https://plus.google.com/+AlbertGraef

       

      Related

      Tickets: #2

  • ssj71

    ssj71 - 2015-05-12
    • status: open --> closed
     

Log in to post a comment.