From: Michael W. <mic...@gm...> - 2010-09-08 10:04:31
|
Hi Alex, Given what you have explained I am happy for the patch to be submitted to the trunk. Regards, Michael On 7 September 2010 16:56, Alex Brooks <a.b...@ma...>wrote: > Hi Michael/David, > > OK, thanks. > > I've fixed up pretty much everything I want to now, so I'm ready to commit > my > patch and give instructions for what needs to be done. It should be fairly > simple I hope. > > I won't bother tagging it, if you want the version prior to my commit you > should get revision 5759. > (You can check it out with: svn co -r 5759 <other stuff>) > > Michael, are you happy for me to commit my patch now (since you can always > get > the version prior if you want) or is there some reason you'd prefer that I > wait till after the 15th? > > > Alex > > > > On Monday 06 September 2010 20:47:54 Michael Warren wrote: > > Hi Alex, > > We (Ben Upcroft, I and some masters students) are currently very active > > users of the Orca image logging and playback abilities so would be at a > > disadvantage if you broke image logging/playing at the current time. > > > > I am well tuned to the imaging parts of the logrecorder and logplayer > > libraries (having written a lot of that capability for the multicamera > > interface) so should be able to help upgrade things once the patches are > > applied. However, we are under the pump at the moment to get results for > > ICRA, so would it be possible to delay this until after the 15th of > > September? After this time I am more than willing to help re-write these > > libraries. It might also be worth making a tag of the current trunk > before > > any more changes? > > > > Regards, > > Michael > > > > On 6 September 2010 20:33, David Lobato <dav...@gm...> wrote: > > > Hi Alex, > > > > > > Right now, I'm sort of close to that "image side of things" so maybe I > > > could help. > > > > > > Just to be sure, what you want is a library that can read/write a > stream > > > of images to/from a file, don't you? > > > > > > I guess you tell images should be logged as .pngs/.jpgs rather than > > > inline because of the size. Maybe it's possible to use some kind of > > > lossless compressor, so you could get rid of big data streams. This way > > > it could be generic. > > > > > > If you can, send me more details about the task so I can figure out if > > > I'm able to help. > > > > > > Have a nice day, > > > David. > > > > > > ------------------------------------- > > > David Lobato Bravo > > > > > > Universidad Rey Juan Carlos > > > c/Tulipan s/n > > > 28933 Móstoles > > > Madrid, Spain > > > http://jderobot.org > > > > > > > > > > > > On Sun, Sep 5, 2010 at 1:46 PM, Alex Brooks < > > > > > > a.b...@ma...> wrote: > > >> Hey guys, > > >> > > >> I just checked in a big patch, there are a lot of changes. > > >> > > >> One of the bigger changes is a parser for slice files, which allows > > >> replacement > > >> of a lot of the hand-generated once-per-interface code with > > >> auto-generated code -- much easier to maintain and to achieve > > >> consistency between interfaces. > > >> > > >> I'm currently in the process of applying auto-generation to > logging/log- > > >> playing (I'm only up to log-playing at the moment). It's a huge > > >> improvement, > > >> previously the amount of cut-and-paste was minimised by an ugly mess > of > > >> templates and inheritance, making the code nigh-unreadable. > > >> > > >> Unfortunately not everything can be auto-generated, there are > > >> exceptions: specifically the image/camera gear, which needs images > > >> logged as .pngs/.jpgs > > >> rather than inline. > > >> > > >> Since I don't really understand this stuff or have cameras (not to > > >> mention time) to test thoroughly, I'm gonna struggle to maintain this. > > >> > > >> I have a bunch of code ready to check in which will break the existing > > >> log- > > >> playing stuff. > > >> I think the cleanest way of handling things would be for > > >> 'orcalogfactory' to > > >> be an autogeneration-only library, and for custom stuff (i.e. images) > to > > >> live > > >> in its own separate library (orcaimagelogfactory?). > > >> > > >> Would someone be willing to help out, by writing this library after I > > >> break > > >> everything? (Or if no-one is using this anyway, will anyone be upset > if > > >> I break it?) It should be pretty straightforward for someone who > knows > > >> the image side of things. > > >> > > >> > > >> Cheers, > > >> > > >> Alex > > >> > > >> -- > > >> ------------------------------ > > >> Dr Alex Brooks > > >> > > >> Marathon Robotics Pty Ltd > > >> National Innovation Centre > > >> 4 Cornwallis Street > > >> Eveleigh, NSW 2015 > > >> Sydney, Australia > > >> Ph: +61 2 9209 4021 > > >> Web: www.marathon-robotics.com > > >> ------------------------------ > > >> > > >> > > >> > ------------------------------------------------------------------------ > > >> ------ This SF.net Dev2Dev email is sponsored by: > > >> > > >> Show off your parallel programming skills. > > >> Enter the Intel(R) Threading Challenge 2010. > > >> http://p.sf.net/sfu/intel-thread-sfd > > >> _______________________________________________ > > >> Orca-robotics-devel mailing list > > >> Orc...@li... > > >> https://lists.sourceforge.net/lists/listinfo/orca-robotics-devel > > > > > > > ------------------------------------------------------------------------- > > > ----- This SF.net Dev2Dev email is sponsored by: > > > > > > Show off your parallel programming skills. > > > Enter the Intel(R) Threading Challenge 2010. > > > http://p.sf.net/sfu/intel-thread-sfd > > > _______________________________________________ > > > Orca-robotics-devel mailing list > > > Orc...@li... > > > https://lists.sourceforge.net/lists/listinfo/orca-robotics-devel > > -- > ------------------------------ > Dr Alex Brooks > > Marathon Robotics Pty Ltd > National Innovation Centre > 4 Cornwallis Street > Eveleigh, NSW 2015 > Sydney, Australia > Ph: +61 2 9209 4021 > Web: www.marathon-robotics.com > ------------------------------ > -- Michael Warren PhD Candidate Axon Building 47 - Room 311 Department of Mechanical Engineering University of Queensland St Lucia, QLD, 4072 |