Hey Andreas,
Big kudos to you for getting all of this stuff fixed/done :-)
Andreas Kloeckner wrote:
>
>
> g_error --> _orbitcpp::error
> g_assert --> assert (from cassert)
> guint --> unsigned int
>
> this ok phil?
I prefer to stick to glib types, because we already require glib and we
know it's portable (it even implements some functions if they dont exist
on systems). I don't think I can be sure to say the same for unsigned
int and assert. You may have more knowledge on this than me, but I take
the working assumption that if glib doesn't port properly then we can
fix it.
> * added FAQ (wanna know what i was doing lately? look here. :((()
> * fixed some tests to remedy problem from FAQ question 1
> * added exceptionlist mechanism
> * removed check for glib from configure.in:
> is necessarily included with ORBit
> * fixed bad bug in smartptr.hh _retn methods
> * fixed bug with empty exceptions
> * reimplemented PortableServer::ObjectId in terms of sequences
> * removed code duplication from sequence template impl, implemented
> missing copy and assignment, made implementation out-of-memory-aware,
> implemented the specified allocbuf/freebuf functions, made the
> sequence template roll its own CPP struct...
>
> ah well, call it a reimplementation of orbitcpp_sequence. :)
Cool! Can't wait to see what you've done!
> oh boy. i am so happy i've got the tests running alright, so I can finally
> commit this funky bunch... have fun!
>
And you,
Cheers,
Phil.
|
