orbitcpp-list

[orbitcpp-list] coding standards for compiler/

[Andreas K. <ak...@ix...>]

Hi Phil,

I've started converting the compiler to our new conventions. (at least
the parts that can be done with sed :) However, i'd suggest we leave the
method names in the compiler the way they are. When I first wrote it, I
chose to use extremely descriptive (i.e. long) method names, and I do
not regret that. But imagine making

writeCPPStubReturnMarshalCode()

something like

write_cpp_stub_return_marshal_code()

(34 characters, as opposed to 29. this is madness.)

what do you think?

andy

Re: [orbitcpp-list] coding standards for compiler/

[Phil D. <ph...@us...>]

Andreas Kloeckner wrote:
> 
> Hi Phil,
> 
> I've started converting the compiler to our new conventions. (at least
> the parts that can be done with sed :) However, i'd suggest we leave the
> method names in the compiler the way they are. When I first wrote it, I
> chose to use extremely descriptive (i.e. long) method names, and I do
> not regret that. 

Yep, I tend to do that alot as well - makes the code easier to follow.

> But imagine making
> 
> writeCPPStubReturnMarshalCode()
> 
> something like
> 
> write_cpp_stub_return_marshal_code()
> 
> (34 characters, as opposed to 29. this is madness.)
> 
> what do you think?
> 


I'm happy for you to leave the compiler method names in 'java' format.

Cheers,

Phil.