orbitcpp-list

[orbitcpp-list] Re: [orbitcpp-commits] orbitcpp philipd

[Andreas K. <ak...@ix...>]

Hi Phil,

> - Added compiler helper function to detect whether type is variable length 
> (and added the function to IDLElement (I ripped these off of the
> orbit-idl code - hope this is okay)

Uh, hope you don't mind me bickering, but I'd rather have 
"isVariableLength()" as a member func of IDLType. It's much more natural,
you don't have to rip off dumb hacks from orbit-idl code, polymorphism
makes your day without lengthy case statements. also mind the fact that
not all IDLTypes are IDLElements (such as short, string).

> - Added struct declaration support for fixed and variable length structs

cool.

phil, i guess i'll be kinda busy till next thursday. don't expect too much
work done by me till that damn calculus exam is all over...

cu
andy

Re: [orbitcpp-list] Re: [orbitcpp-commits] orbitcpp philipd

[Phil d. <ph...@us...>]

Andreas Kloeckner wrote:
> 
> Hi Phil,
> 
> > - Added compiler helper function to detect whether type is variable length
> > (and added the function to IDLElement (I ripped these off of the
> > orbit-idl code - hope this is okay)
> 
> Uh, hope you don't mind me bickering, but I'd rather have
> "isVariableLength()" as a member func of IDLType. It's much more natural,
> you don't have to rip off dumb hacks from orbit-idl code, polymorphism
> makes your day without lengthy case statements. also mind the fact that
> not all IDLTypes are IDLElements (such as short, string).

Of course you're right. I did consider using polymorphism, but it was
like 'two minutes to rip off the (already tested) ORBit code verses 1/4
hour to write a few recursive virtual functions and test them' and I was
keen to get the struct stuff working. I'll see if I can refactor it for
the next commit.

> phil, i guess i'll be kinda busy till next thursday. don't expect too much
> work done by me till that damn calculus exam is all over...
> 

Okay - BTW Good luck,

Cheers,

Phil.