[orbitcpp-list] my patches to ORBit

[Andreas K. <ak...@ix...>]

Hi Phil & all,

all the patches have been included in current cvs except the sequence
demarshalling one. [of course, the one that is most important] here are
the last messages i exchanged with elliot concerning the thing.

------------------------------------------------------------------------
from elliot:
------------------------------------------------------------------------

On Thu, 13 Apr 2000, Andreas Kloeckner wrote:

> Elliot Lee wrote:
> > 
> > On Thu, 13 Apr 2000, Andreas Kloeckner wrote:
> > 
> > > ORBit doesn't set the _maximum member of a sequence struct when
> > > demarshalling. The following patch against ORBit 0.5.1 fixes this.
> > 
> > _maximum is useless, realistically, unless demarshalling, 
> 
> but it's specified and we need it for orbit-c++.

I'm curious why :)

> > and your patch
> > doesn't set it correctly (because length can be smaller than maximum).
> 
> look closer. maximum = length only for unbounded sequences.

Hmm sorry.

-- Elliot
"Moron of the week" for four years running
------------------------------------------------------------------------
my reply: [sent apr 14]
------------------------------------------------------------------------

Elliot Lee wrote:
> > > _maximum is useless, realistically, unless demarshalling,
> >
> > but it's specified and we need it for orbit-c++.
> 
> I'm curious why :)

when implementing operator= for sequences, we use _maximum for
determining the size of the buffer to allocate. (_maximum needs to be
identical after assignment) now orbit gives us a zero _maximum,
resulting in no allocation, resulting in a CORBA::NO_MEMORY exception on
our side.

we could have a hacky workaround like max=length on our side, but this
is crap.

> > > and your patch
> > > doesn't set it correctly (because length can be smaller than maximum).
> >
> > look closer. maximum = length only for unbounded sequences.
> 
> Hmm sorry.

would you apply the patch? please? :)

cya
andy
------------------------------------------------------------------------

he has not answered or committed so far, so i've come to believe he is
nowhere near appreciating this patch. what can we do?

later
andy