[Orbit-python-list] Re: Fix for __import__()

[Christian R. R. <ki...@as...>]

On 6 Oct 2001, Jason Tackaberry wrote:

> > Review would be appreciated; this problem is currently blocking my ability
> > to release my FiscalPrinter software publically.
>
> Okay, this looks good.  But clean up your formatting before your check
> it in; use tabs to indent, not spaces.

Tack, I'll clean this up and check it in. However, I'd like to point out
we are hardly standardized in this sense and I don't know if tabs are the
right way at all. Should I provide the jwz link "why tabs suck?" :-)

IMHO, we should use spaces instead of tabs, and standardize on either 4 or
8 spaces. I prefer 4 myself, but that's not a big deal.

(The ChangeLog is ts=3 and spaced, for instance, and a lot of
CORBAmodule.c is mixed - makes it hard to fix.)

> Incidentally, I see that you checked in the last patch to
> CORBA__ORB_init, but I don't see an entry in the ChangeLog.  Ahem. :)

Sorry, I had written it but left it out, fixed.

Will check in soon.

Take care,
--
Christian Reis, Senior Engineer, Async Open Source, Brazil.
http://async.com.br/~kiko/ | [+55 16] 272 3330 | NMFL