Re: [Orbit-python-list] Uploaded patch

[Jason T. <ta...@li...>]

> I'd be glad to explain them.  Which ones?

Well, one of them was in client.c:stub_func() - I wasn't sure why you
needed to g_slist_free the newly removed link.  But then I went and checked
the documentation and there it was in black and white: "Removes an element
without freeing it."  Words cannot express how silly I feel.  Thanks for
catching that.

I'm not sure, however, why you removed this from client.c:set_attribute():

if (ad->mode == CORBA_ATTR_READONLY) {
   raise_system_exception("IDL:omg.org/CORBA/NO_PERMISSION:1.0", 0,
                          CORBA_COMPLETED_NO, "attribute %s readonly",
                          ad->name);
   return -1;
}

Yes checks should be done at the server end as well (I'll merge that patch
along with this one), but it certainly doesn't hurt to check at the client,
since it will potentially eliminate needless communication with the server.

>   Cool.  Thanks.  I'll probably build a Debian package for it, and
> convert it to an RPM one (with alien).  I'll send them to you for
> publishing on the Sourceforge download zone, if you like.

I would, yes.  Thanks. :)

Jason.