Re: [Orbit-python-list] Threads?
Status: Inactive
Brought to you by:
tack
From: Jason T. <ta...@li...> - 2000-08-02 14:01:44
|
> version? I've submitted them to Sourceforge in May, and had no > feedback... And I'd prefer running an official version rather than my > own patched one. I fully understand they might be a bit kludgy, but I > feel they are really useful. Hi Roland, I'm terribly sorry for not getting back to you on those. I probably saw them when you posted them, thought, "Oh yes I had better look at that when I have more time," and totally forgot. Anyway, I _will_ review your patches tonight and let you know. Certainly I don't see a problem with the patch to prevent a client from modifying a read-only attribute -- it should definitely do that. It should send an appropriate exception to the client, however. I'll make these changes and merge the patch in. The other one I'm not so sure about. Yes I admit that inserting the POA in the __main__ dictionary is A Bad Thing (it's a FIXME item for sure). But I think your patch will result in straying even further away from the CORBA bindings for Python guidelines, and really, we are only moving from one kludge to another. Your way is technically cleaner, but we aren't realy solving the original problem, plus moving to a version with this change will require modifying code that uses ORBit-Python. I'm open for arguments, though. Do we want the POA as a value in the caller's dictionary? Or should it be within the CORBA module? Jason. |